Re: [PATCH 1/2] iommu: Statically set module owner

Will Deacon
2021-03-25T17:09:01Z

On Fri, Mar 19, 2021 at 12:52:01PM +0000, Robin Murphy wrote:
> It happens that the 3 drivers which first supported being modular are
> also ones which play games with their pgsize_bitmap, so have non-const
> iommu_ops where dynamically setting the owner manages to work out OK.
> However, it's less than ideal to force that upon all drivers which want
> to be modular - like the new sprd-iommu driver which now has a potential
> bug in that regard - so let's just statically set the module owner and
> let ops remain const wherever possible.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> This is something I hadn't got round to sending earlier, so now rebased
> onto iommu/next to accommodate the new driver :)
>
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 +
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 +
> drivers/iommu/sprd-iommu.c | 1 +
> drivers/iommu/virtio-iommu.c | 1 +
> include/linux/iommu.h | 9 +--------
> 5 files changed, 5 insertions(+), 8 deletions(-)

Acked-by: Will Deacon <will@kernel.org>

Will