Re: [PATCH 2/2] iommu: Streamline registration interface

Christoph Hellwig
2021-03-19T13:42:48Z

> +int iommu_device_register(struct iommu_device *iommu, const struct iommu_ops *ops,

It would be nice to avoid the pointlessly overlong line here.

> + struct device *hwdev)
> {
> + iommu->ops = ops;
> + if (hwdev)
> + iommu->fwnode = hwdev->fwnode;

This function could use a kerneldoc comment now. Especially the hwdev
agument isn't exactly obvious.