From: Christoph Hellwig <hch@infradead.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: will@kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iommu: Streamline registration interface
Date: Fri, 19 Mar 2021 13:42:19 +0000 [thread overview]
Message-ID: <20210319134219.GB1063154@infradead.org> (raw)
In-Reply-To: <95f69c593aa9dd57a5333e490dc06b8bae27fedf.1616157612.git.robin.murphy@arm.com>
> +int iommu_device_register(struct iommu_device *iommu, const struct iommu_ops *ops,
It would be nice to avoid the pointlessly overlong line here.
> + struct device *hwdev)
> {
> + iommu->ops = ops;
> + if (hwdev)
> + iommu->fwnode = hwdev->fwnode;
This function could use a kerneldoc comment now. Especially the hwdev
agument isn't exactly obvious.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-03-19 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 12:52 [PATCH 1/2] iommu: Statically set module owner Robin Murphy
2021-03-19 12:52 ` [PATCH 2/2] iommu: Streamline registration interface Robin Murphy
2021-03-19 13:42 ` Christoph Hellwig [this message]
2021-03-25 17:12 ` Will Deacon
2021-03-19 13:39 ` [PATCH 1/2] iommu: Statically set module owner Christoph Hellwig
2021-03-25 17:08 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319134219.GB1063154@infradead.org \
--to=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox