From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE9AC433DB for ; Tue, 30 Mar 2021 17:49:35 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64E52619CF for ; Tue, 30 Mar 2021 17:49:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64E52619CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EEE2060760; Tue, 30 Mar 2021 17:49:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fu5oxEvSL3jj; Tue, 30 Mar 2021 17:49:34 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id EEA446071E; Tue, 30 Mar 2021 17:49:33 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DB022C000C; Tue, 30 Mar 2021 17:49:33 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 723DDC000A for ; Tue, 30 Mar 2021 17:49:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 60622404CC for ; Tue, 30 Mar 2021 17:49:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VA-l2Ou1soD3 for ; Tue, 30 Mar 2021 17:49:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by smtp4.osuosl.org (Postfix) with ESMTPS id 80057404BB for ; Tue, 30 Mar 2021 17:49:32 +0000 (UTC) IronPort-SDR: pZzvUl7PRpWSt6MBTj3QIlIuxyxQ5DslUGKOxsOMMlRwlOZp8H1dUNeua0bf1HZhtZmBR+HyUd VUYKE8kZ9HPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="276997592" X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="276997592" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 10:49:30 -0700 IronPort-SDR: FKvLAxU7/mf8+wi6h4BaZT9P8YOdspJgTsnJqqPxQyxc4VzrRXVhYEv6CxKxIvTfM2cRClkXwf b6SYPfDpn1+g== X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="393695340" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 10:49:30 -0700 Date: Tue, 30 Mar 2021 10:52:00 -0700 From: Jacob Pan To: Guenter Roeck Subject: Re: [PATCH v2 1/4] iommu/vt-d: Enable write protect for supervisor SVM Message-ID: <20210330105200.418bc42b@jacob-builder> In-Reply-To: <20210322175338.GA24424@roeck-us.net> References: <1614680040-1989-1-git-send-email-jacob.jun.pan@linux.intel.com> <1614680040-1989-2-git-send-email-jacob.jun.pan@linux.intel.com> <20210322175338.GA24424@roeck-us.net> Organization: OTC X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: "Tian, Kevin" , Raj Ashok , Jean-Philippe Brucker , Sanjay Kumar , LKML , iommu@lists.linux-foundation.org, "Luck, Tony" , David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Guenter, On Mon, 22 Mar 2021 10:53:38 -0700, Guenter Roeck wrote: > On Tue, Mar 02, 2021 at 02:13:57AM -0800, Jacob Pan wrote: > > Write protect bit, when set, inhibits supervisor writes to the read-only > > pages. In supervisor shared virtual addressing (SVA), where page tables > > are shared between CPU and DMA, IOMMU PASID entry WPE bit should match > > CR0.WP bit in the CPU. > > This patch sets WPE bit for supervisor PASIDs if CR0.WP is set. > > > > Signed-off-by: Sanjay Kumar > > Signed-off-by: Jacob Pan > > --- > > ia64:defconfig: > > drivers/iommu/intel/pasid.c: In function 'pasid_enable_wpe': > drivers/iommu/intel/pasid.c:536:22: error: implicit declaration of > function 'read_cr0' drivers/iommu/intel/pasid.c:539:23: error: > 'X86_CR0_WP' undeclared > > Maybe it _is_ time to retire ia64 ? Good catch, sorry for the late reply. I guess otherwise I will have to do some #ifdef? There are many basic x86 helpers are missing in ia64. +Tony Thanks, Jacob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu