From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9972BC433B4 for ; Mon, 3 May 2021 22:57:12 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 195B8613BC for ; Mon, 3 May 2021 22:57:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 195B8613BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A2DA68414E; Mon, 3 May 2021 22:57:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 58-UaLH_mcv0; Mon, 3 May 2021 22:57:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTP id 99C4A83E0B; Mon, 3 May 2021 22:57:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 818E9C000D; Mon, 3 May 2021 22:57:10 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id A47B6C0001 for ; Mon, 3 May 2021 22:57:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8095540F33 for ; Mon, 3 May 2021 22:57:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=ziepe.ca Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z1R3b78nrNe6 for ; Mon, 3 May 2021 22:57:08 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by smtp4.osuosl.org (Postfix) with ESMTPS id 621D04067A for ; Mon, 3 May 2021 22:57:07 +0000 (UTC) Received: by mail-qk1-x72e.google.com with SMTP id 8so6830034qkv.8 for ; Mon, 03 May 2021 15:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xZZm+3MFuedFCkj1MfVgDeM954nHR/3fXds6exXmQfs=; b=ouRSQEEjT38vBUuV862SeUlllVCT6eH9A/DLELLKUUCUzA1ShVzuWVXQ1MBHwfUp52 o2iY2zmGF5v6LzhQq+GBDBerKVAePtFNVbGHvM38jkoESd9bfzmAI5TW5EmfL78E08Qn KIGOFGei7/yO8yCpBYVzXmS09DZEEm+pTY6CGCqEpqr9/YKTEYQHHgmnMtxfiJhxhwEM PI6Kaqk2dLQBbp3lySC34PVTv8PJZyC4fg+IILviuxHg1B8L5kSFMxjKrsIeWCcV13AT K2K+mR+5wr9SajVl5e5SOe9bFPiH9IuQFOm4a7VNUrSG+YlFkkc7yhkY+MYykwPRCxJe dU1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xZZm+3MFuedFCkj1MfVgDeM954nHR/3fXds6exXmQfs=; b=hlWApdu7MtuilNUNcPhjlP8k164KqGMGmLDLKdWUTejjDXBJzYlrbapw+4g9DtWbyj 9P2tNSYlVZgEuyPCDacGbdAQu89Bo93FvTSbwtD6lKPbd4dMj/HsRp9p6BMFxi96WcAE OLIz0iDIwcHAmwBexSNCiRcBk92JwICuyFm42JNTJdLzNx2g9xwdm1CnxxwUB8zTXEu3 lL4ghHEYuKoGnhSRw9oaP8MUvvr9TVQXuqGOhNC6tgP34lDMkwYY5uWFrd5bof4bLyvN B56vMONftQsPPZfg2ZLj57tfUy6J7uk6CXF3mig/aE7JKA2I1QL25Zsr3l8WXd+sWMMp tdOA== X-Gm-Message-State: AOAM530EpTOFEOjnym3iaClvEGhBJLGa85Tl2V97wmzdSILZXgu0C8I4 CEHz4ZSGTSKBr/sgRMp4cTjuNQ== X-Google-Smtp-Source: ABdhPJwB6nytiC0oDMbKJRBwSIes/jqgsePpJ+MXFQRNiesNGamVx4ATl+XqEZHAz4GA6Yzrb48bvQ== X-Received: by 2002:a37:a9c8:: with SMTP id s191mr6160737qke.430.1620082626750; Mon, 03 May 2021 15:57:06 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id c17sm897865qtd.71.2021.05.03.15.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 15:57:06 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1ldhUv-00H3QZ-2z; Mon, 03 May 2021 19:57:05 -0300 Date: Mon, 3 May 2021 19:57:05 -0300 From: Jason Gunthorpe To: John Hubbard Subject: Re: [PATCH 04/16] PCI/P2PDMA: Refactor pci_p2pdma_map_type() to take pagmap and device Message-ID: <20210503225705.GA2047089@ziepe.ca> References: <20210408170123.8788-1-logang@deltatee.com> <20210408170123.8788-5-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: linux-pci@vger.kernel.org, Dave Hansen , linux-nvme@lists.infradead.org, Stephen Bates , linux-mm@kvack.org, Jason Ekstrand , Ira Weiny , Christoph Hellwig , Minturn Dave B , Matthew Wilcox , Bjorn Helgaas , Daniel Vetter , linux-block@vger.kernel.org, Dan Williams , Jakowski Andrzej , Xiong Jianxin , Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Logan Gunthorpe , Christian =?utf-8?B?S8O2bmln?= X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, May 03, 2021 at 02:54:26PM -0700, John Hubbard wrote: > I guess my main concern here is that there are these pci*() functions > that somehow want to pass around struct device. Well, this is the main issue - helpers being used inside IOMMU code should not be called pci* functions. This is some generic device p2p interface that happens to only support PCI to PCI transfers today. Jason _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu