From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C21BC433EF for ; Wed, 13 Oct 2021 15:46:17 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B14C610FE for ; Wed, 13 Oct 2021 15:46:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B14C610FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5809840523; Wed, 13 Oct 2021 15:46:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6naTr5PASnla; Wed, 13 Oct 2021 15:46:15 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id ED54F4018B; Wed, 13 Oct 2021 15:46:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BE1ACC0011; Wed, 13 Oct 2021 15:46:14 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2AF06C000D for ; Wed, 13 Oct 2021 15:46:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0A24F40206 for ; Wed, 13 Oct 2021 15:46:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9Y8Q1ILs3Hg9 for ; Wed, 13 Oct 2021 15:46:10 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by smtp2.osuosl.org (Postfix) with ESMTPS id B9DE4400BF for ; Wed, 13 Oct 2021 15:46:10 +0000 (UTC) Received: by mail-pg1-x535.google.com with SMTP id e7so2719796pgk.2 for ; Wed, 13 Oct 2021 08:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5P0ocxXM0vPODGkh8na4Mfy39/EYyFv4GMRrvhNNOUo=; b=gfAizaxTiwRe31oPHuSEfCuoU3UyNzjvSGFjRtR0+20ybGnOJHR2SNvIUYXuMY2xpD gjbOwicFvptk+HxbA9gztDS/NFb/B9PCmms4ywTb+W6ZfybGlSGnqIF9BrEyW3lnzugF 1xOsRizGgXSxqW3rE2o7H3pOyE6LnVUrXJS6JM8CS2LKu70yomZ+jIXvV9GC/9hEoAdh pZgLdZj46NdkkNldf1y6Zal4VF0OHZO5HByoWBC8S5+MsG5/UJx0h6V+EfRdjNyAV2md QHEhpyLmWUQN/xdLKYedMbdiT11toyum2MbaAnr8R6GfEwVc/Pi4akUF4ElQql0esd+K tzhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5P0ocxXM0vPODGkh8na4Mfy39/EYyFv4GMRrvhNNOUo=; b=6m1I8GFRf0byqfvMduBvMqCHc+2dJDpwX1Hx4LNXGORpgN8WPAUBwwIPck7fr8BDmW S+60SzZmyN98T0p4k3zpMgMYXOD4B/Zlm6l2+0LQ+A0K+QC5quPoGlc5T9D80JqHEdEr fwXCuJDIzHS1hRbdmDWs6i7jY4rcVkdAuI0X0lkHHs13U6SJTxiuehETag2t6SbJRxmf V3S/R382GO66Kp0qxfPMz9XlnKkYTLfeeYhh/vCBAsquw4Kjw3M2Te+eoLUZdGpFh94A b5l6eNvnjypWt1oP4VOEu8GE4dmmU/RiwJWGgLy9r0C4ybkwfnDtK5vd+l94jboQba0j WURA== X-Gm-Message-State: AOAM533k4BUGVQo12qN7LPGCkPpG1fMlXUu5G2UimnWIs1L+Ur4o8MRy 1li69Yog11b8Yik0dro4xhILGg== X-Google-Smtp-Source: ABdhPJxOS97EPwZsGm56NgXmycC48sC/ZWo8Q8DTT9IZBXIVEcdfskLSNijWrQkjT1bVWFJiZLyKew== X-Received: by 2002:aa7:949c:0:b0:44c:a0df:2c7f with SMTP id z28-20020aa7949c000000b0044ca0df2c7fmr128668pfk.34.1634139970091; Wed, 13 Oct 2021 08:46:10 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id x27sm2452841pfo.90.2021.10.13.08.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 08:46:09 -0700 (PDT) Date: Wed, 13 Oct 2021 09:46:04 -0600 From: Mathieu Poirier To: "Michael S. Tsirkin" Subject: Re: [PATCH RFC] virtio: wrap config->reset calls Message-ID: <20211013154604.GB4135908@p14s> References: <20211013105226.20225-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013105226.20225-1-mst@redhat.com> Cc: Latchesar Ionkov , nvdimm@lists.linux.dev, Dominique Martinet , Stefan Hajnoczi , kvm@vger.kernel.org, David Hildenbrand , David Airlie , Viresh Kumar , Jason Wang , linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, Gerd Hoffmann , linux-scsi@vger.kernel.org, Will Deacon , v9fs-developer@lists.sourceforge.net, Anton Ivanov , Jean-Philippe Brucker , Linus Walleij , Dave Jiang , Herbert Xu , linux-arm-kernel@lists.infradead.org, Miklos Szeredi , Richard Weinberger , Bartosz Golaszewski , Takashi Iwai , Gonglei , Kalle Valo , "James E.J. Bottomley" , Jakub Kicinski , Ira Weiny , virtualization@lists.linux-foundation.org, Jeff Dike , Vivek Goyal , Stefano Garzarella , Ohad Ben-Cohen , Johan Hedberg , Arnd Bergmann , Amit Shah , Eric Van Hensbergen , Marcel Holtmann , linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-block@vger.kernel.org, Vishal Verma , Luiz Augusto von Dentz , Matt Mackall , Dan Williams , Jaroslav Kysela , Cristian Marussi , Jens Axboe , Jie Deng , "Martin K. Petersen" , linux-gpio@vger.kernel.org, Greg Kroah-Hartman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-bluetooth@vger.kernel.org, iommu@lists.linux-foundation.org, Anton Yakovlev , Daniel Vetter , Sudeep Holla , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Johannes Berg , "Enrico Weigelt, metux IT consult" , "David S. Miller" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote: > This will enable cleanups down the road. > The idea is to disable cbs, then add "flush_queued_cbs" callback > as a parameter, this way drivers can flush any work > queued after callbacks have been disabled. > > Signed-off-by: Michael S. Tsirkin > --- > arch/um/drivers/virt-pci.c | 2 +- > drivers/block/virtio_blk.c | 4 ++-- > drivers/bluetooth/virtio_bt.c | 2 +- > drivers/char/hw_random/virtio-rng.c | 2 +- > drivers/char/virtio_console.c | 4 ++-- > drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++---- > drivers/firmware/arm_scmi/virtio.c | 2 +- > drivers/gpio/gpio-virtio.c | 2 +- > drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +- > drivers/i2c/busses/i2c-virtio.c | 2 +- > drivers/iommu/virtio-iommu.c | 2 +- > drivers/net/caif/caif_virtio.c | 2 +- > drivers/net/virtio_net.c | 4 ++-- > drivers/net/wireless/mac80211_hwsim.c | 2 +- > drivers/nvdimm/virtio_pmem.c | 2 +- > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- > drivers/scsi/virtio_scsi.c | 2 +- > drivers/virtio/virtio.c | 5 +++++ > drivers/virtio/virtio_balloon.c | 2 +- > drivers/virtio/virtio_input.c | 2 +- > drivers/virtio/virtio_mem.c | 2 +- > fs/fuse/virtio_fs.c | 4 ++-- > include/linux/virtio.h | 1 + > net/9p/trans_virtio.c | 2 +- > net/vmw_vsock/virtio_transport.c | 4 ++-- > sound/virtio/virtio_card.c | 4 ++-- > 26 files changed, 39 insertions(+), 33 deletions(-) > > static struct virtio_driver virtio_pmem_driver = { > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 8e49a3bacfc7..6a11952822df 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -1015,7 +1015,7 @@ static void rpmsg_remove(struct virtio_device *vdev) > size_t total_buf_space = vrp->num_bufs * vrp->buf_size; > int ret; > > - vdev->config->reset(vdev); > + virtio_reset_device(vdev); > Reviewed-by: Mathieu Poirier > ret = device_for_each_child(&vdev->dev, NULL, rpmsg_remove_device); > if (ret) _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu