From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E27E5C433EF for ; Wed, 13 Oct 2021 16:53:04 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C70C61056 for ; Wed, 13 Oct 2021 16:53:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8C70C61056 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4712E40847; Wed, 13 Oct 2021 16:53:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r1_xlIrUd0gi; Wed, 13 Oct 2021 16:53:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id B386940849; Wed, 13 Oct 2021 16:53:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6B812C000F; Wed, 13 Oct 2021 16:53:02 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3AD18C000D; Wed, 13 Oct 2021 16:18:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 28D7483004; Wed, 13 Oct 2021 16:18:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s7OUHJKr7CYF; Wed, 13 Oct 2021 16:18:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp1.osuosl.org (Postfix) with ESMTP id 2F86882EDB; Wed, 13 Oct 2021 16:18:18 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57B9E6D; Wed, 13 Oct 2021 09:18:17 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 25FED3F694; Wed, 13 Oct 2021 09:18:07 -0700 (PDT) Date: Wed, 13 Oct 2021 17:18:04 +0100 From: Cristian Marussi To: "Michael S. Tsirkin" Subject: Re: [PATCH RFC] virtio: wrap config->reset calls Message-ID: <20211013161804.GB6376@e120937-lin> References: <20211013105226.20225-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211013105226.20225-1-mst@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Mailman-Approved-At: Wed, 13 Oct 2021 16:53:01 +0000 Cc: Latchesar Ionkov , nvdimm@lists.linux.dev, Dominique Martinet , Stefan Hajnoczi , kvm@vger.kernel.org, David Hildenbrand , David Airlie , Viresh Kumar , Linus Walleij , Jeff Dike , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, Gerd Hoffmann , Will Deacon , v9fs-developer@lists.sourceforge.net, Anton Ivanov , Jean-Philippe Brucker , Dave Jiang , Herbert Xu , linux-scsi@vger.kernel.org, Miklos Szeredi , Richard Weinberger , Bartosz Golaszewski , Takashi Iwai , Gonglei , linux-arm-kernel@lists.infradead.org, "Martin K. Petersen" , "James E.J. Bottomley" , Jakub Kicinski , Ira Weiny , virtualization@lists.linux-foundation.org, Jason Wang , Vivek Goyal , Stefano Garzarella , Ohad Ben-Cohen , Johan Hedberg , Arnd Bergmann , Amit Shah , Eric Van Hensbergen , linux-remoteproc@vger.kernel.org, Marcel Holtmann , linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-block@vger.kernel.org, Vishal Verma , Luiz Augusto von Dentz , Matt Mackall , Dan Williams , Jaroslav Kysela , Kalle Valo , Jens Axboe , Jie Deng , Mathieu Poirier , linux-gpio@vger.kernel.org, Greg Kroah-Hartman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-bluetooth@vger.kernel.org, iommu@lists.linux-foundation.org, Anton Yakovlev , Daniel Vetter , Sudeep Holla , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Johannes Berg , "Enrico Weigelt, metux IT consult" , "David S. Miller" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Oct 13, 2021 at 06:55:31AM -0400, Michael S. Tsirkin wrote: > This will enable cleanups down the road. > The idea is to disable cbs, then add "flush_queued_cbs" callback > as a parameter, this way drivers can flush any work > queued after callbacks have been disabled. > > Signed-off-by: Michael S. Tsirkin > --- > arch/um/drivers/virt-pci.c | 2 +- > drivers/block/virtio_blk.c | 4 ++-- > drivers/bluetooth/virtio_bt.c | 2 +- > drivers/char/hw_random/virtio-rng.c | 2 +- > drivers/char/virtio_console.c | 4 ++-- > drivers/crypto/virtio/virtio_crypto_core.c | 8 ++++---- > drivers/firmware/arm_scmi/virtio.c | 2 +- > drivers/gpio/gpio-virtio.c | 2 +- > drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +- > drivers/i2c/busses/i2c-virtio.c | 2 +- > drivers/iommu/virtio-iommu.c | 2 +- > drivers/net/caif/caif_virtio.c | 2 +- > drivers/net/virtio_net.c | 4 ++-- > drivers/net/wireless/mac80211_hwsim.c | 2 +- > drivers/nvdimm/virtio_pmem.c | 2 +- > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- > drivers/scsi/virtio_scsi.c | 2 +- > drivers/virtio/virtio.c | 5 +++++ > drivers/virtio/virtio_balloon.c | 2 +- > drivers/virtio/virtio_input.c | 2 +- > drivers/virtio/virtio_mem.c | 2 +- > fs/fuse/virtio_fs.c | 4 ++-- > include/linux/virtio.h | 1 + > net/9p/trans_virtio.c | 2 +- > net/vmw_vsock/virtio_transport.c | 4 ++-- > sound/virtio/virtio_card.c | 4 ++-- > 26 files changed, 39 insertions(+), 33 deletions(-) > [snip] > diff --git a/drivers/firmware/arm_scmi/virtio.c b/drivers/firmware/arm_scmi/virtio.c > index 11e8efb71375..6b8d93fe8848 100644 > --- a/drivers/firmware/arm_scmi/virtio.c > +++ b/drivers/firmware/arm_scmi/virtio.c > @@ -452,7 +452,7 @@ static void scmi_vio_remove(struct virtio_device *vdev) > * outstanding message on any vqueue to be ignored by complete_cb: now > * we can just stop processing buffers and destroy the vqueues. > */ > - vdev->config->reset(vdev); > + virtio_reset_device(vdev); > vdev->config->del_vqs(vdev); > /* Ensure scmi_vdev is visible as NULL */ > smp_store_mb(scmi_vdev, NULL); Reviewed-by: Cristian Marussi Thanks, Cristian _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu