From: Christoph Hellwig <hch@lst.de>
To: David Rientjes <rientjes@google.com>
Cc: iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/4] dma-direct: leak memory that can't be re-encrypted
Date: Thu, 21 Oct 2021 09:22:33 +0200 [thread overview]
Message-ID: <20211021072233.GA29169@lst.de> (raw)
In-Reply-To: <c116b963-1a53-bb5a-feab-2abaee6fd86@google.com>
On Tue, Oct 19, 2021 at 12:56:36PM -0700, David Rientjes wrote:
> > - dma_set_encrypted(dev, vaddr, 1 << page_order);
> > + if (dma_set_encrypted(dev, vaddr, 1 << page_order)) {
> > + pr_warn_ratelimited(
> > + "leaking DMA memory that can't be re-encrypted\n");
> > + }
>
> Is this actually leaking the memory?
Yes, it should return here.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-10-21 7:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:29 dma-direct cleanups Christoph Hellwig
2021-10-19 12:29 ` [PATCH 1/4] dma-direct: factor out dma_set_{de,en}crypted helpers Christoph Hellwig
2021-10-19 19:54 ` David Rientjes via iommu
2021-10-21 6:59 ` Christoph Hellwig
2021-10-19 12:29 ` [PATCH 2/4] dma-direct: leak memory that can't be re-encrypted Christoph Hellwig
2021-10-19 19:56 ` David Rientjes via iommu
2021-10-21 7:22 ` Christoph Hellwig [this message]
2021-10-19 12:29 ` [PATCH 3/4] dma-direct: clean up the remapping checks in dma_direct_alloc Christoph Hellwig
2021-10-19 12:29 ` [PATCH 4/4] dma-direct: factor out a helper for DMA_ATTR_NO_KERNEL_MAPPING allocations Christoph Hellwig
2021-10-19 19:57 ` David Rientjes via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021072233.GA29169@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox