From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8850C433EF for ; Tue, 9 Nov 2021 14:27:30 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9672861054 for ; Tue, 9 Nov 2021 14:27:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9672861054 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 58FFC403CE; Tue, 9 Nov 2021 14:27:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hgu5wVfhAMFL; Tue, 9 Nov 2021 14:27:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 61DF4400AA; Tue, 9 Nov 2021 14:27:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 47B66C0012; Tue, 9 Nov 2021 14:27:29 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1FD34C000E for ; Tue, 9 Nov 2021 14:27:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F271880F13 for ; Tue, 9 Nov 2021 14:27:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vqBJNzxuotdE for ; Tue, 9 Nov 2021 14:27:27 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7577F80CF7 for ; Tue, 9 Nov 2021 14:27:27 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4500A67373; Tue, 9 Nov 2021 15:27:23 +0100 (CET) Date: Tue, 9 Nov 2021 15:27:22 +0100 From: Christoph Hellwig To: Robin Murphy Subject: Re: [PATCH 06/10] dma-direct: refactor the !coherent checks in dma_direct_alloc Message-ID: <20211109142722.GE23489@lst.de> References: <20211021090611.488281-1-hch@lst.de> <20211021090611.488281-7-hch@lst.de> <1732d247-e82a-2250-d12e-0d5988d670a9@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1732d247-e82a-2250-d12e-0d5988d670a9@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: iommu@lists.linux-foundation.org, Christoph Hellwig , David Rientjes X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Nov 04, 2021 at 12:36:08PM +0000, Robin Murphy wrote: > How about: > remap = IS_ENABLED(CONFIG_DMA_DIRECT_REMAP); > > if (remap && ...) > > for a bit less indentation? FWIW I reckon it's slightly more obvious that > way round. Done. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu