From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2E23C433F5 for ; Wed, 8 Dec 2021 20:30:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 62B834013D; Wed, 8 Dec 2021 20:30:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p-7Y_ZvlGgvr; Wed, 8 Dec 2021 20:30:33 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 1D6BC400FC; Wed, 8 Dec 2021 20:30:33 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D03ECC001E; Wed, 8 Dec 2021 20:30:32 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 083F8C0012 for ; Wed, 8 Dec 2021 20:30:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 02D4240525 for ; Wed, 8 Dec 2021 20:30:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=nvidia.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id myFFEtaUmyMw for ; Wed, 8 Dec 2021 20:30:30 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2061e.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::61e]) by smtp4.osuosl.org (Postfix) with ESMTPS id DAAA54047A for ; Wed, 8 Dec 2021 20:30:30 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZF4Ldyd5avd8rSz1CzQAJZiGJRlLibqDXUjUNCZR6aJdo5vIkPRnlfuARqQi0sw2EI0ivu3qny01jnI+rHYSN3FKhpLyOyyHnuIY8m7Ubis6GNGkdbQoUHv2qssH7IxWaPV7vdl0aIP9Hr57JJPmiD7N8+qK1yjD4ERoqN5OKeu8NaFCD3itwNAOQEcC6ryn3YUWnwssLqUD6P48xnRYu2/GMXyRHRS8M8ZLFVTs5Ml7dPwMRdmKafwjnrzQV4hRj8NIy8sU9f1CzzBiCACDpLRDvlNZhzrN+GlZd7pnBB/DM4SFyxseON1LbyG6yN7/5P9X2rHQf3syqW7oVTd0qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ro57GieshXGyt29cyw9FiGrIK8UEqSvfYwza4CFCUp8=; b=YsYNu8HzCHTPStlTPYhakUCSu4sAv2qJw5NwB1f+hn6v+29lnpwalbiBTPNUtfYQTp1oYiF5w2E/BNOpRLXntReu1ZT/gd0axRXaigj8Ej7pJIHpXm25Eiw8vLkWdMuMDAw1MFmT+MPpUD2Webtq9aoaJ31I5qXPMGdUUjTwcuFYC2ChZGl6ppY5VdbH4V3M5YqDgBAdv5i4h/P7TnerVQTJEUqr63OBabWGFXkUrQ9C8mUbROir5BB/K3IXyRibmERziMzpvLwwNy6euz2BY0x/DdCM5NKrbfBreWinzes57lSwfO7hgqFVxrW5kkuq20c9BqWOI3OOGwBNcHVq8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ro57GieshXGyt29cyw9FiGrIK8UEqSvfYwza4CFCUp8=; b=A6Do4H5kQjSvbU5bBGaYesNTzI//VKiaLHJVrbHx4fU9xLWC2hXkRMYAPAz6S7WLmZ6cFaOI5GwNtOsLTFsD65WlvYonAxoLpxwKxEjrhglMnyD8XFlBt95DD4QmRF6eLbfgaABzigaN5fCTRhyHVlhtQ3dFrZu261JLdE7VoSiSDXhgPDIGM2+i7Kfgs6XWcEd7SvFjUCIrJhSuUmOJYfpAeYR5J9E+832OLJvtsAszObZv5Qxky9tI2NLNMNXqCGofchecexCV+hYvCGKvvnyxJgr7zsUWY9ghQYQUKXIvPYZ6PeluM80hHOdBj2iG3mR4MQ4+jj+g90dAPUg3aQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22) by BL1PR12MB5380.namprd12.prod.outlook.com (2603:10b6:208:314::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Wed, 8 Dec 2021 20:30:24 +0000 Received: from BL0PR12MB5506.namprd12.prod.outlook.com ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.013; Wed, 8 Dec 2021 20:30:24 +0000 Date: Wed, 8 Dec 2021 16:30:22 -0400 To: Jacob Pan Subject: Re: [PATCH 4/4] dmaengine: idxd: Use DMA API for in-kernel DMA with PASID Message-ID: <20211208203022.GF6385@nvidia.com> References: <1638884834-83028-1-git-send-email-jacob.jun.pan@linux.intel.com> <1638884834-83028-5-git-send-email-jacob.jun.pan@linux.intel.com> <20211208131358.GR6385@nvidia.com> <20211208115516.1d36fed9@jacob-builder> Content-Disposition: inline In-Reply-To: <20211208115516.1d36fed9@jacob-builder> X-ClientProxiedBy: YT1PR01CA0043.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2e::12) To BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fea34adf-db46-466a-830e-08d9ba899005 X-MS-TrafficTypeDiagnostic: BL1PR12MB5380:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i3HUhgS1dW1SAPSuESYc2zChmsP47LXeIPz7kGCTauMFBNJVUxBiACAhobtbACi+6soncwTplQiAO3Q/mwj1WTM7FszG/5TdWz3UeoXTBP9wTXG6naUzcRHI36jkgcmFE8DSWkj1MnDUXkU9pLYapjKfFViReJyj1xlKEiKNMEa3U2FY+nIAPlaRPZR2ZvlNKpdzVrORfs9uADB+bxxf3PGxA3Z70MBE1J854o/XXn7MzxcR5D4hZciar55hhqknbkVs0J08izrUrgDv/lGcCoM/+k9FpQY+c64Hfig1iXbXl9dQ2WDzR4Bif8sVFBZtpuDHMCg6zRLR89sSTz/Z775t0bPwP//d18rxuQPp5R8ksh9LKzEh/15or1OrjzgSh/FLfRYBc+vG2++uJfG9Z+ePslspGxyvZ1ylMyO5pEHuvHI7ZK0888uL5/nunnz9bYD4YMa7rphlagJ9oON9ELbmu3JX08yiduMrv5/m9EpVsxMjJzFieMpl1lD4ubw8+H/4HK8ONTURAfXkFn2tAjhyJ+Y2Ytl8e5y90FvOAK/rc1FLW5XKDeANOffEySApaX9tuFgI7tpaL4+ok2/aPtdlMW+jOU5qON2pRmKZxCYW/QuaIRwvsL5jVj3TWs9CsrjiNifNIE8LRqutA3uj2g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL0PR12MB5506.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(33656002)(7416002)(86362001)(2616005)(8676002)(26005)(6486002)(6506007)(508600001)(6916009)(186003)(54906003)(66476007)(36756003)(66556008)(5660300002)(316002)(1076003)(6512007)(4326008)(38100700002)(2906002)(8936002)(66946007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6/QwHCQuEO7p4vKYLjWdtyJ4FcbRl4WpYj8NABP86ugCZYXpb2vgsnTNYt40?= =?us-ascii?Q?8w2djtyUQkwt55QeVHURBq5tHuYvCpsfh8oVkq2ANtnKwMnJtHyZjXwwHUlo?= =?us-ascii?Q?jRf+aaX0nFiubfcJlvf40l3YFd4mHorxxvkKSeTXjQR0r2Tf18KPNQUE/hbk?= =?us-ascii?Q?j4I3yOpK7KNEYmWi+X6yMzOXmpqgvWvwkA6FpuLY5fpeMOMtPTAze97XAWDd?= =?us-ascii?Q?qr/at7nW0WOuiO5yF7uCEqncpn21c92f/FWK0smJuYAHcZJmhHHNap98mqQk?= =?us-ascii?Q?kmd7yGur665i1r6cAFnV1aZyDrGLShMKnRUN9kb2bLR4HNOGhjpgWobf6lkq?= =?us-ascii?Q?YZg29h3a/eZeKi+z9BIJwvD7ltVi6WdktojRkPE9zCDvzUSottDJegojKUxZ?= =?us-ascii?Q?xZ4QGtL1h/To3blTnR1rTTPwsHDGsvyAUW9e6cIM3eUKupHEApz5F545tFGK?= =?us-ascii?Q?JIHuEHkXLo9dyGEcsGesPZPJQAFrhZperp2DVq9x13U4VKa2g+cnMlqyxwpb?= =?us-ascii?Q?usIud/CdWlNZQHR8PSB5q1/1JIK4vKKS/ls1NOlEQCaSbjk2/Szc3SULwuQ4?= =?us-ascii?Q?D0MfMEwX69mcpeVY8yQ/Yhvv/0UKXanVa+3qTOSwHocy1Uzr0SRjodzIDEJq?= =?us-ascii?Q?fMxm96xEnEukdcSMFaucNb66NW04Qd4aPfWaas0rWlfP/ycM2a3Rg/msdFEW?= =?us-ascii?Q?LRp5gNAz2NIROfLm2HqprAYt8zD16e+jed6mEZkgchPeqkv+CQ8uBuC4MVj+?= =?us-ascii?Q?0XSqFuRjhT/wswR1qYMe4JyVwpvrmXxHZOyblwI74vTqX7Yk3E/jsWOKPXt0?= =?us-ascii?Q?zhIFXdK+4072owukazAPBJyav53QqnmM/Nhvq7uanVwjb+GuApQ6aVz6S5Z4?= =?us-ascii?Q?eb+qNB8PUBB4esS1K9pKzBC4sf3oWat2IULeRmagCHfi9AmYDG9nZyASMS8u?= =?us-ascii?Q?iiw+YEx/xJ7aLlxqJDuPviOPVjPbLdLBTBfUm2sjON9DK53n2YNCrZWGfXlT?= =?us-ascii?Q?qGfaMPEkf2v3A24AJ/5p2yFwHGCQQbVLsIBGnwoG9Vn5+23oQaTOrwU1lNJY?= =?us-ascii?Q?CgL1qFhK9rcLGqLgfNYrk/+cD+vxysjati2PYK225+O4LxUwTe4xZMziKoYR?= =?us-ascii?Q?vuLg1ob7VgSZyXeFGOExrYOKqP+thgXFVUbcakynegTEN8Y5gwe8Z1sc4G9O?= =?us-ascii?Q?qXUAbIAGzCRwQWoDbAxO+2Ze2ppYLWApNxjz2y6bxtUAvO+FsZZ4V9f19mHO?= =?us-ascii?Q?uKEg/CMtG3HfAYSawjLs4Yy+w1Env/37M6CmK/T0y1rsJZ4PkQvM+NowkzQI?= =?us-ascii?Q?bGhbwM+W4sOJ/U29Ip3D0YMGDdaKHUXWQ5HdQuRljNqJ6GVH1Xz0yCsli7Ia?= =?us-ascii?Q?j++0gTIGifz5lfSlBBm93m7XdydVFqOARVUhBjuKGviYe/vQRr1KImrJBpAl?= =?us-ascii?Q?TE0Wm7B0ljsCcoRaIUSpAUMPbcUZLOa1Xh1VnUsQPwwjLrOu/sarx9RXIGu5?= =?us-ascii?Q?8qwzthCVhNfiflfFJHJkYSYJRNgGN8TwFofIpCKigEURmYEXxPmNV5SK6uEm?= =?us-ascii?Q?QsQFYNkO9fZjyjc5Zm0=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: fea34adf-db46-466a-830e-08d9ba899005 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 20:30:24.2029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 63MNvlVetje51RRDfmLnjJQSu5aaWGr+ieV5H7j4RFMWLXAkuo5ZGH+N9lh19QAm X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5380 Cc: "Tian, Kevin" , Tony Luck , Dave Jiang , Raj Ashok , Greg Kroah-Hartman , "Kumar, Sanjay K" , LKML , Christoph Hellwig , iommu@lists.linux-foundation.org, Jacob Pan , Barry Song <21cnbao@gmail.com>, Dan Williams , Jean-Philippe Brucker , "Zanussi, Tom" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jason Gunthorpe via iommu Reply-To: Jason Gunthorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Dec 08, 2021 at 11:55:16AM -0800, Jacob Pan wrote: > Hi Jason, > > On Wed, 8 Dec 2021 09:13:58 -0400, Jason Gunthorpe wrote: > > > > This patch utilizes iommu_enable_pasid_dma() to enable DSA to perform > > > DMA requests with PASID under the same mapping managed by DMA mapping > > > API. In addition, SVA-related bits for kernel DMA are removed. As a > > > result, DSA users shall use DMA mapping API to obtain DMA handles > > > instead of using kernel virtual addresses. > > > > Er, shouldn't this be adding dma_map/etc type calls? > > > > You can't really say a driver is using the DMA API without actually > > calling the DMA API.. > The IDXD driver is not aware of addressing mode, it is up to the user of > dmaengine API to prepare the buffer mappings. Here we only set up the PASID > such that it can be picked up during DMA work submission. I tested with > /drivers/dma/dmatest.c which does dma_map_page(), map_single etc. also > tested with other pieces under development. Ignoring the work, doesn't IDXD prepare the DMA queues itself, don't those need the DMA API? I'm still very confused how this can radically change from using kSVA to DMA API and NOT introduce some more changes than this. They are not the same thing, they do not use the same IOVA's. Did you test this with bypass mode off? Jason _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu