From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C442C433EF for ; Mon, 21 Mar 2022 11:53:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id D2A8B408BD; Mon, 21 Mar 2022 11:53:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HCERAPfeLisp; Mon, 21 Mar 2022 11:53:16 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 51A5D405A6; Mon, 21 Mar 2022 11:53:16 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 26494C001A; Mon, 21 Mar 2022 11:53:16 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 48735C000B for ; Mon, 21 Mar 2022 11:53:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 36A2060D73 for ; Mon, 21 Mar 2022 11:53:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=nvidia.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U6-dQZNo4Qn1 for ; Mon, 21 Mar 2022 11:53:13 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on20612.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e8a::612]) by smtp3.osuosl.org (Postfix) with ESMTPS id 801C860AC2 for ; Mon, 21 Mar 2022 11:53:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZb25REvrbKSoPgXnQzo7e7kTwuMoSPJAjkwA1T2LeCuSinRiIyJQyytz+YBjJkxr+eR/MGdB3w/gwzM9gwtarFCjf6AJAZTq+nGQdr02r8GBjBlqEtOlVsQfVauuis8hptCxvdVUlBchvvPRSEE7fkBjsm9AUHj4BX2UaVH4D70m3wCoZGf0U3A6aILPttUYpzd4DZMjXlO+EtvUM3AxztPunjLxPQ+pcR7hY24VKPET9unl5Ee9gyjaiARD4MBm8YbrI0kPi+3sJVXxRdJxkr9VNIPAelxrB4mJE2VCKWHq4RyiwlhErVZxbJnARAI1s/bAhj57PrioyMxpb0BFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kx8NsBkvvpMYV1uduBD3QJFGkOBXTeErLIbar2SO9hM=; b=jFJGiGkpCvFckch0j/ukAaplNnqj/jg/v8gDh+a5Bboi6AC6lM3PU1Xn6hi/dCy+yHV1SS/lNuksBHLg8ZFvUyo0NAhKJGMd88FDr+/lYka9/7o56qZE1UZbgU215LDsnqJ5r31QAm5woE+2xAe2kjkObsiFJFLfw/WZTPY/htYMrjxxY3IxSJdg8TW7hUvoqGZVF3Bi/vMMiBBcDeDDKSDKcesR2k/hr5QoDKJpXuWMnUper/d59VrF0kFcSIaHjBBWb/CigdwO41+F82I7YOt5uodYqWdaUva1osMirh0DsI2wtQjTh7hDSH8kWiIg3/J94AEPbrGbs5XW8sQQFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kx8NsBkvvpMYV1uduBD3QJFGkOBXTeErLIbar2SO9hM=; b=Eervnx/ng/j6Mwp1qUWiZDGC4N+bbaRZCwp9elgSFV1c1vJPU+R5MhWqb+ah8NA5IQUQ1ppcZbPCYsBiQT99uEb4cYNyTo3IbjnzA5PfXHncOm5ceryHt93/m3eD+/VvJsFKSY8rhBUly/pphkkAXknOUhDIj5cwSo62GzO9plnbEInpuhxfJhU/KUkCSRJ84lkSBSeMtGOSkWtovVe8tjTLCuzv1T+ro5VmR5dLN65MrWOQEOppcTIRxDPsMShF8xGxenu1hif3OZy6yRhRw+8Ggn2cqqDz1AKosW3QjP0XLn+IrqI9PKgqMADkljo9W2ST4uyxkXu1WJYbrHL07A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) by CH2PR12MB4309.namprd12.prod.outlook.com (2603:10b6:610:a4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Mon, 21 Mar 2022 11:53:09 +0000 Received: from MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::11a0:970a:4c24:c70c]) by MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::11a0:970a:4c24:c70c%5]) with mapi id 15.20.5081.023; Mon, 21 Mar 2022 11:53:09 +0000 Date: Mon, 21 Mar 2022 08:53:08 -0300 To: "Tian, Kevin" Subject: Re: [PATCH RFC 03/11] iommu: Add attach/detach_dev_pasid domain ops Message-ID: <20220321115308.GJ11336@nvidia.com> References: <20220320064030.2936936-1-baolu.lu@linux.intel.com> <20220320064030.2936936-4-baolu.lu@linux.intel.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BL1PR13CA0351.namprd13.prod.outlook.com (2603:10b6:208:2c6::26) To MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04a068cd-1514-4106-0e6d-08da0b315e59 X-MS-TrafficTypeDiagnostic: CH2PR12MB4309:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s+VrihQxxqCD6cPhzyQv7NKSqoEgiSMXrsu3brgQfMJ5aW3kQi8OgcHTadlZRjrN2PfOyHs/Q3ViTvoZaYNzSAc61c7eOQCQBw6imWTAdYgDhgMOsVz2jJelk4eH8FDhQCqGbiiHNBvIatqr8i9oBRIsOdeclITrg0OzMTJwOd2BbhkaZL3Tx9E+iTDKcaFG6ntbuGUhffVI5ryDi3Ego+px9H06GHGegtAebc1f0psLHKCntS+j9Si5jNQhSMpjYN8q5/lUzfkQAzoat7b85A3VFUxh8B5VFxb+xTPWBa2vK43oWoQuYbiecOO/NUW9ys7YPK0JQPwylAZeUGp82ealWQe/ayRdbOoCSjG5gTtE6kIfGesbI9FRdJU0GmgM+098F455mz+u+0lTrkJqLn2W4WBTbYM7ctZQoqAncdLkggy2cp6m9KI7MJWh5YYUtFRSXM/TuEG5wygHl6vIRGX0KP8OyTWm8fTfEssBCugZ8CwSAb6fbF+jy4xN8aoUMSYyxmVEKjaUor1duJm9DsV2Vn5GNGQiaAf2ltKJPHa0qHWjaLHvwRF2QA9DV2L0lsGDYj0lPgn8Q61YEVjOZPhmIpZelh2H5wKwwc3JX6V4ihwJSRUZkwtfqm7JjIArKQgBA6ozcr+sxP+vDb7XgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4192.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(6486002)(6512007)(83380400001)(1076003)(2616005)(7416002)(4326008)(66476007)(66946007)(8676002)(66556008)(26005)(54906003)(6916009)(186003)(86362001)(38100700002)(8936002)(316002)(4744005)(36756003)(33656002)(6506007)(5660300002)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ie/9J31zj+IAyMNBc+A/IkvYEfI7FFoafAYYjvaHdGAOOfJ38VIb67JHJxhW?= =?us-ascii?Q?Nq3gefPUe48CCwDDfR5FBVkk7qwDYcAlUpwOZv/4Kv1UkpM+WzC4EaBaMNdq?= =?us-ascii?Q?+uUK9s8G2iQBoQGYcZECfGVcAXYC/SuXOOtKmu/InCWKUZgErI/HHL7XY/wB?= =?us-ascii?Q?y+y03rR5N1QsB4hIsOBJGmADtqEcX4GAQEFmMH5FMC5/yFy6z8w3eTOxI8I0?= =?us-ascii?Q?mPYXHT7jMJ+RqVE+ufFk6rCKC8X1phtL46KexQVnsDvlu1y4w3EVAk/N2KSS?= =?us-ascii?Q?6N62Adw1Tf9FcnbkJLqMLqljRR2+MLdgMLoM38yqeEtwqwRZVLo10+LV7lbr?= =?us-ascii?Q?5mc8BE37oQqBKtjZrSQ5GMQij445vHX6qwBkUpJ5xqPDTLaEdOKlPxsR/ylA?= =?us-ascii?Q?q9/gnmXxt7VI5V87+VSJuGKgnWAnBbWEWsgdJ/9ulPNPjRP+zjiWZFcyoj9Y?= =?us-ascii?Q?9fa9okmYR3fFiUN5GkneJAqLhQin5tVGS08jsMdGKFbe99aC7FYDE6EHVrjC?= =?us-ascii?Q?2Uy/25OGJpakAs7Mf2rb7gtOzzntys4gu6i+5bC0o1pRBfEw+TcBGrq5dqID?= =?us-ascii?Q?CCMsUEc8zr/8oN4vWPdZ+jzBkCEkqg5IW5mOLmZB/b0VxPjhvJG3T8dU4/qf?= =?us-ascii?Q?qSPPQvj1AipTTnEoK+9r/5dSbIuFH2CflQS5CFJEJChP7r2b1Jlqx8BzG/G3?= =?us-ascii?Q?zGbuNXoIqEA/xOiKDxT6hSQWp08B0f4ClmdTICu77mhXKNm4b/qqF4XwP2vD?= =?us-ascii?Q?ckhIjo4CZpix6vqHSSBBC6DHNry6jZpw2yo7dYtnAWGAW18XsN88i+FcZDZM?= =?us-ascii?Q?cZON0wVdfpka5MEPR6ZzZ2MYIFHselPmA+m1T7UKL9FywWDex12n5PVYfRDC?= =?us-ascii?Q?dlbuQhN4X9rTZmPqMeQYk08iTszfMo7Xev+os6nH2Hut9Tmz2PZDu9LSHzta?= =?us-ascii?Q?qHlngbIWCFO72CtIggHrYRohH8rH274ERXg240bX9CHbCIdZdeSrcAnzU1oY?= =?us-ascii?Q?/J5a+DiHdE/makZQRYjjbYepYnFy2N4B9501DNlJc88MjhB/4BRfCmuHL2og?= =?us-ascii?Q?Q45+XbZa025Xcvs5Aq42SwmAclh9+SvNdCunMShoUVJ9MdUJ6fziGj7Qq4OA?= =?us-ascii?Q?AsxIQTaOhjTFzzBSm/CjedYF7GdrMHX5KOGzGQwuqm0VFKquiI7UyA+XK/iD?= =?us-ascii?Q?8jbEiXmWrg62FOviu3P8iLfDycE9m2VpzezGw/XyyUJ9pOISrUQ+5Wj6RvQz?= =?us-ascii?Q?JXt+nJsoJUgbhzXDhGx7xQvU1atTj7WNNmdOiZEn1c6Ts1+GVEQicJDkDzfn?= =?us-ascii?Q?AFdTbMb5K23QoMpDQkQalSVsJKTmPU/qNHsoE+JFEsPxzUItqz3WXPs6zCro?= =?us-ascii?Q?98Xemv7TG4RQQB3CIV2HkEiXg/pMZiKDdwOSvZ16st+CWrNj63zPCeLPktqQ?= =?us-ascii?Q?SXS+TzDGKulTl66DjunHQSZNRnzcFyB1?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04a068cd-1514-4106-0e6d-08da0b315e59 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 11:53:09.1650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sL31kX3sDTNbKK58lKtMJ1LRtgR7vnmGNQTa0pp/IM694a2aX9Nmi9WyYpTLMWR4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4309 Cc: "Raj, Ashok" , Will Deacon , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Jean-Philippe Brucker , "iommu@lists.linux-foundation.org" , "Pan, Jacob jun" , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jason Gunthorpe via iommu Reply-To: Jason Gunthorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Mar 21, 2022 at 07:13:49AM +0000, Tian, Kevin wrote: > /* > * To keep things simple, SVA currently doesn't support IOMMU groups > * with more than one device. Existing SVA-capable systems are not > * affected by the problems that required IOMMU groups (lack of ACS > * isolation, device ID aliasing and other hardware issues). > */ > if (iommu_group_device_count(group) != 1) > goto out_unlock; > > btw I didn't see any safeguard on above assumption in device hotplug path > to a group which already has SVA enabled... This is because using device_count is always wrong for these kinds of tests. The exclusion needs to be built up from the new owner mechanism. Once the device is in SVA mode it is the same as having exclusive ownership against any other probes() Jason _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu