From: Jason Gunthorpe via iommu <iommu@lists.linux-foundation.org>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Robin Murphy <robin.murphy@arm.com>,
Qian Cai <quic_qiancai@quicinc.com>,
iommu@lists.linux-foundation.org, Will Deacon <will@kernel.org>
Subject: Re: [PATCH] iommu: iommu_group_claim_dma_owner() must always assign a domain
Date: Wed, 4 May 2022 08:53:25 -0300 [thread overview]
Message-ID: <20220504115325.GA50202@nvidia.com> (raw)
In-Reply-To: <f213ba6f-2cbc-e4b2-c510-16ef8ef0a337@linux.intel.com>
On Wed, May 04, 2022 at 07:48:58PM +0800, Baolu Lu wrote:
> > + /*
> > + * New drivers do not implement detach_dev, so changing the domain is
> > + * done by calling attach on the new domain. Drivers should implement
> > + * this so that DMA is always translated by either the new, old, or a
> > + * blocking domain. DMA should never become untranslated.
> > + *
> > + * Note that this is called in error unwind paths, attaching to a
> > + * domain that has already been attached cannot fail.
> > + */
> > ret = __iommu_group_for_each_dev(group, group->default_domain,
> ^^^^^^^^^^^^^^^^^^^^^^
>
> I suppose this should be @new_domain, right?
Yes, thank you
Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-05-04 11:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 0:11 [PATCH] iommu: iommu_group_claim_dma_owner() must always assign a domain Jason Gunthorpe via iommu
2022-05-04 8:22 ` Nicolin Chen via iommu
2022-05-04 11:57 ` Jason Gunthorpe via iommu
2022-05-04 11:48 ` Baolu Lu
2022-05-04 11:53 ` Jason Gunthorpe via iommu [this message]
2022-05-04 14:35 ` Baolu Lu
2022-05-04 14:38 ` Jason Gunthorpe via iommu
2022-05-04 14:55 ` Baolu Lu
2022-05-04 15:00 ` Jason Gunthorpe via iommu
2022-05-04 14:42 ` Robin Murphy
2022-05-04 14:54 ` Jason Gunthorpe via iommu
2022-05-04 15:29 ` Robin Murphy
2022-05-04 18:20 ` Jason Gunthorpe via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504115325.GA50202@nvidia.com \
--to=iommu@lists.linux-foundation.org \
--cc=baolu.lu@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=quic_qiancai@quicinc.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox