From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 775D07A for ; Thu, 14 Jul 2022 05:12:55 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 8B49567373; Thu, 14 Jul 2022 07:12:48 +0200 (CEST) Date: Thu, 14 Jul 2022 07:12:48 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, Stephen Bates , Christoph Hellwig , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell Subject: Re: [PATCH v8 01/13] lib/scatterlist: add flag for indicating P2PDMA segments in an SGL Message-ID: <20220714051248.GA23381@lst.de> References: <20220708165104.5005-1-logang@deltatee.com> <20220708165104.5005-2-logang@deltatee.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220708165104.5005-2-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) Do we need the dma_ prefix for the flags field? That's just what it is used for now. Otherwise looks good: Reviewed-by: Christoph Hellwig