From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EF8620F5 for ; Fri, 20 Oct 2023 16:44:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fQlQ9/2w" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697820260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aMAA1wMWvircrEJMOG5j/39HJSPTO4z+wh6TBaHy/FU=; b=fQlQ9/2w2t7hjmAMh9bJTsHywPfoRsDr2E+Fvo85ZdL1G2z3R1uc+VB8sQ1Nz90flw8GzD DlQUDu7HasdRT/go7vE7htSYk6c/n6gwSoAP96PQ8pIXWiOpX+OeHB7B9YeQWEK4AXFslM IlRxkROimZzqvQYXlk0To6ZUhO37dts= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-U1S3RahdOOG_eWQr1B_uRQ-1; Fri, 20 Oct 2023 12:44:19 -0400 X-MC-Unique: U1S3RahdOOG_eWQr1B_uRQ-1 Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-35740de180aso9502395ab.2 for ; Fri, 20 Oct 2023 09:44:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697820259; x=1698425059; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aMAA1wMWvircrEJMOG5j/39HJSPTO4z+wh6TBaHy/FU=; b=MQikvECsu/qsplXOULV55CbpMtVYSAyZuoc+1ZwOQRLop5k1EflBOgff9LHDPrH4oJ DDNzYHFXx8euzA6aR8c2eVQRd1WU5li/5y4u11gn4UZKcldAvL/imFRdg79+4I9fBd+8 RyFT1Y1kyrVL7LTC+LwacyZMiyCwpqeTyadRIpodiVnlGezM7X5My58T19CHKgmTRPum 1twzv/6uwJrVzG7Ulj9u4cllHDYd59/OnU/kYqwahyoQxE/cDFhR4J39k5BAfBnx/qGe RO7WmktpeiN9eWcM6Q1vh7dN0MmYelAmrZN8o1PSSUOKlz6HLA0UZJh1drpoBY2QBFVn chXQ== X-Gm-Message-State: AOJu0YxuR6GFlmk8Dpkla7Pp/nRdtoZM6YxM66u46pSoFZYwEQgAhuzQ GTrR9EaiXCot8WLNGL4C2XdOLPU55b3wy5eB5lGCKmURUDtd5RqHW9LYVKGxHjxQW35siuJeq5T kWmOedksrq8KADWA= X-Received: by 2002:a92:ce0f:0:b0:357:43f9:7cd3 with SMTP id b15-20020a92ce0f000000b0035743f97cd3mr2818996ilo.19.1697820258855; Fri, 20 Oct 2023 09:44:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjlAr/6whJcCAcwaHbLC1LI969MhkVBkP6O7Vf1x7JsQrJ9u+Z0KIYfnZf6F1DmPbkzHOE+w== X-Received: by 2002:a92:ce0f:0:b0:357:43f9:7cd3 with SMTP id b15-20020a92ce0f000000b0035743f97cd3mr2818972ilo.19.1697820258596; Fri, 20 Oct 2023 09:44:18 -0700 (PDT) Received: from redhat.com ([38.15.60.12]) by smtp.gmail.com with ESMTPSA id u14-20020a056e021a4e00b0035745066abfsm684255ilv.21.2023.10.20.09.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 09:44:18 -0700 (PDT) Date: Fri, 20 Oct 2023 10:44:17 -0600 From: Alex Williamson To: Joao Martins Cc: iommu@lists.linux.dev, Jason Gunthorpe , Kevin Tian , Shameerali Kolothum Thodi , Lu Baolu , Yi Liu , Yi Y Sun , Nicolin Chen , Joerg Roedel , Suravee Suthikulpanit , Will Deacon , Robin Murphy , Zhenzhong Duan , kvm@vger.kernel.org, Brett Creeley , Yishai Hadas Subject: Re: [PATCH v4 03/18] iommufd/iova_bitmap: Move symbols to IOMMUFD namespace Message-ID: <20231020104417.5849664f.alex.williamson@redhat.com> In-Reply-To: <20231018202715.69734-4-joao.m.martins@oracle.com> References: <20231018202715.69734-1-joao.m.martins@oracle.com> <20231018202715.69734-4-joao.m.martins@oracle.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 18 Oct 2023 21:27:00 +0100 Joao Martins wrote: > Have the IOVA bitmap exported symbols adhere to the IOMMUFD symbol > export convention i.e. using the IOMMUFD namespace. In doing so, > import the namespace in the current users. This means VFIO and the > vfio-pci drivers that use iova_bitmap_set(). > > Suggested-by: Jason Gunthorpe > Signed-off-by: Joao Martins > --- > drivers/iommu/iommufd/iova_bitmap.c | 8 ++++---- > drivers/vfio/pci/mlx5/main.c | 1 + > drivers/vfio/pci/pds/pci_drv.c | 1 + > drivers/vfio/vfio_main.c | 1 + > 4 files changed, 7 insertions(+), 4 deletions(-) > Reviewed-by: Alex Williamson > diff --git a/drivers/iommu/iommufd/iova_bitmap.c b/drivers/iommu/iommufd/iova_bitmap.c > index f54b56388e00..0a92c9eeaf7f 100644 > --- a/drivers/iommu/iommufd/iova_bitmap.c > +++ b/drivers/iommu/iommufd/iova_bitmap.c > @@ -268,7 +268,7 @@ struct iova_bitmap *iova_bitmap_alloc(unsigned long iova, size_t length, > iova_bitmap_free(bitmap); > return ERR_PTR(rc); > } > -EXPORT_SYMBOL_GPL(iova_bitmap_alloc); > +EXPORT_SYMBOL_NS_GPL(iova_bitmap_alloc, IOMMUFD); > > /** > * iova_bitmap_free() - Frees an IOVA bitmap object > @@ -290,7 +290,7 @@ void iova_bitmap_free(struct iova_bitmap *bitmap) > > kfree(bitmap); > } > -EXPORT_SYMBOL_GPL(iova_bitmap_free); > +EXPORT_SYMBOL_NS_GPL(iova_bitmap_free, IOMMUFD); > > /* > * Returns the remaining bitmap indexes from mapped_total_index to process for > @@ -389,7 +389,7 @@ int iova_bitmap_for_each(struct iova_bitmap *bitmap, void *opaque, > > return ret; > } > -EXPORT_SYMBOL_GPL(iova_bitmap_for_each); > +EXPORT_SYMBOL_NS_GPL(iova_bitmap_for_each, IOMMUFD); > > /** > * iova_bitmap_set() - Records an IOVA range in bitmap > @@ -423,4 +423,4 @@ void iova_bitmap_set(struct iova_bitmap *bitmap, > cur_bit += nbits; > } while (cur_bit <= last_bit); > } > -EXPORT_SYMBOL_GPL(iova_bitmap_set); > +EXPORT_SYMBOL_NS_GPL(iova_bitmap_set, IOMMUFD); > diff --git a/drivers/vfio/pci/mlx5/main.c b/drivers/vfio/pci/mlx5/main.c > index 42ec574a8622..5cf2b491d15a 100644 > --- a/drivers/vfio/pci/mlx5/main.c > +++ b/drivers/vfio/pci/mlx5/main.c > @@ -1376,6 +1376,7 @@ static struct pci_driver mlx5vf_pci_driver = { > > module_pci_driver(mlx5vf_pci_driver); > > +MODULE_IMPORT_NS(IOMMUFD); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Max Gurtovoy "); > MODULE_AUTHOR("Yishai Hadas "); > diff --git a/drivers/vfio/pci/pds/pci_drv.c b/drivers/vfio/pci/pds/pci_drv.c > index ab4b5958e413..dd8c00c895a2 100644 > --- a/drivers/vfio/pci/pds/pci_drv.c > +++ b/drivers/vfio/pci/pds/pci_drv.c > @@ -204,6 +204,7 @@ static struct pci_driver pds_vfio_pci_driver = { > > module_pci_driver(pds_vfio_pci_driver); > > +MODULE_IMPORT_NS(IOMMUFD); > MODULE_DESCRIPTION(PDS_VFIO_DRV_DESCRIPTION); > MODULE_AUTHOR("Brett Creeley "); > MODULE_LICENSE("GPL"); > diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c > index 40732e8ed4c6..a96d97da367d 100644 > --- a/drivers/vfio/vfio_main.c > +++ b/drivers/vfio/vfio_main.c > @@ -1693,6 +1693,7 @@ static void __exit vfio_cleanup(void) > module_init(vfio_init); > module_exit(vfio_cleanup); > > +MODULE_IMPORT_NS(IOMMUFD); > MODULE_VERSION(DRIVER_VERSION); > MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR(DRIVER_AUTHOR);