Linux IOMMU Development
 help / color / mirror / Atom feed
From: Daniel Mentz <danielmentz@google.com>
To: iommu@lists.linux.dev
Cc: Thierry Reding <treding@nvidia.com>,
	Frank Rowand <frowand.list@gmail.com>,
	 Rob Herring <robh@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <jroedel@suse.de>,
	 Daniel Mentz <danielmentz@google.com>
Subject: [PATCH] iommu: Fix printk arg in of_iommu_get_resv_regions()
Date: Tue,  7 Nov 2023 22:22:26 -0800	[thread overview]
Message-ID: <20231108062226.928985-1-danielmentz@google.com> (raw)

The variable phys is defined as (struct resource *) which aligns with
the printk format specifier %pr. Taking the address of it results in a
value of type (struct resource **) which is incompatible with the format
specifier %pr. Therefore, remove the address of operator (&).

Fixes: a5bf3cfce8cb ("iommu: Implement of_iommu_get_resv_regions()")
Signed-off-by: Daniel Mentz <danielmentz@google.com>
---
 drivers/iommu/of_iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 157b286e36bf..d1f3b92560bc 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -191,7 +191,7 @@ iommu_resv_region_get_type(struct device *dev,
 	if (start == phys->start && end == phys->end)
 		return IOMMU_RESV_DIRECT;
 
-	dev_warn(dev, "treating non-direct mapping [%pr] -> [%pap-%pap] as reservation\n", &phys,
+	dev_warn(dev, "treating non-direct mapping [%pr] -> [%pap-%pap] as reservation\n", phys,
 		 &start, &end);
 	return IOMMU_RESV_RESERVED;
 }
-- 
2.42.0.869.gea05f2083d-goog


             reply	other threads:[~2023-11-08  6:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08  6:22 Daniel Mentz [this message]
2023-11-08 13:12 ` [PATCH] iommu: Fix printk arg in of_iommu_get_resv_regions() Thierry Reding
2023-12-01  9:17 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231108062226.928985-1-danielmentz@google.com \
    --to=danielmentz@google.com \
    --cc=frowand.list@gmail.com \
    --cc=iommu@lists.linux.dev \
    --cc=jroedel@suse.de \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox