Linux IOMMU Development
 help / color / mirror / Atom feed
From: Vasant Hegde <vasant.hegde@amd.com>
To: <iommu@lists.linux.dev>, <joro@8bytes.org>
Cc: <suravee.suthikulpanit@amd.com>, Vasant Hegde <vasant.hegde@amd.com>
Subject: [PATCH 5/6] iommu/amd: Remove redundant error check in amd_iommu_probe_device()
Date: Thu, 18 Jan 2024 09:01:04 +0000	[thread overview]
Message-ID: <20240118090105.5864-6-vasant.hegde@amd.com> (raw)
In-Reply-To: <20240118090105.5864-1-vasant.hegde@amd.com>

iommu_init_device() is not returning -ENOTSUPP since commit 61289cbaf6c8
("iommu/amd: Remove old alias handling code").

No functional change intended.

Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
---
 drivers/iommu/amd/iommu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index 6bb4f2dc5194..431febbb0fab 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -2175,8 +2175,7 @@ static struct iommu_device *amd_iommu_probe_device(struct device *dev)
 
 	ret = iommu_init_device(iommu, dev);
 	if (ret) {
-		if (ret != -ENOTSUPP)
-			dev_err(dev, "Failed to initialize - trying to proceed anyway\n");
+		dev_err(dev, "Failed to initialize - trying to proceed anyway\n");
 		iommu_dev = ERR_PTR(ret);
 		iommu_ignore_device(iommu, dev);
 	} else {
-- 
2.31.1


  parent reply	other threads:[~2024-01-18  9:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18  9:00 [PATCH 0/6] iommu/amd: Misc cleanup Vasant Hegde
2024-01-18  9:01 ` [PATCH 1/6] iommu/amd: Remove unused PPR_* macros Vasant Hegde
2024-01-18  9:01 ` [PATCH 2/6] iommu/amd: Remove unused IOVA_* macro Vasant Hegde
2024-01-18  9:01 ` [PATCH 3/6] iommu/amd: Remove unused APERTURE_* macros Vasant Hegde
2024-01-18  9:01 ` [PATCH 4/6] iommu/amd: Remove duplicate function declarations from amd_iommu.h Vasant Hegde
2024-01-18  9:01 ` Vasant Hegde [this message]
2024-01-18  9:01 ` [PATCH 6/6] iommu/amd: Remove EXPORT_SYMBOL for perf counter related functions Vasant Hegde
2024-01-19 19:37 ` [PATCH 0/6] iommu/amd: Misc cleanup Alejandro Jimenez
2024-01-22  3:49   ` Vasant Hegde
2024-02-06 12:58 ` Jason Gunthorpe
2024-02-09 10:41 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240118090105.5864-6-vasant.hegde@amd.com \
    --to=vasant.hegde@amd.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=suravee.suthikulpanit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox