From: Jason Gunthorpe <jgg@nvidia.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Michael Shavit <mshavit@google.com>,
iommu@lists.linux.dev, Nicolin Chen <nicolinc@nvidia.com>
Subject: Re: [bug report] iommu/arm-smmu-v3: Refactor write_ctx_desc
Date: Fri, 2 Feb 2024 10:59:07 -0400 [thread overview]
Message-ID: <20240202145907.GT1455070@nvidia.com> (raw)
In-Reply-To: <46d7086c-36fc-4668-b95b-454e339b94c0@moroto.mountain>
On Fri, Feb 02, 2024 at 05:45:43PM +0300, Dan Carpenter wrote:
> On Fri, Feb 02, 2024 at 09:35:57AM -0400, Jason Gunthorpe wrote:
> > It won't silence Dan's warning warning but it will correct the bug for
> > now.
>
> I could just modify the database to say that
> arm_smmu_update_ctx_desc_devices() doesn't call arm_smmu_write_ctx_desc()
> with preempt disabled. I don't think it will silence any true
> positives. That's a one liner for me.
But it does and it found this bug :)
After my series we have things like this:
cdptr = arm_smmu_get_cd_ptr(master, master_domain->ssid);
if (WARN_ON(!cdptr))
continue;
Which indicates the paths that expect to have been pre-allocated. We
could also have a no_alloc parameter to really make the checker happy?
Jason
next prev parent reply other threads:[~2024-02-02 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 12:18 [bug report] iommu/arm-smmu-v3: Refactor write_ctx_desc Dan Carpenter
2024-02-02 12:33 ` Michael Shavit
2024-02-02 13:35 ` Jason Gunthorpe
2024-02-02 14:45 ` Dan Carpenter
2024-02-02 14:59 ` Jason Gunthorpe [this message]
2024-02-05 10:56 ` Dan Carpenter
2024-02-03 8:00 ` Michael Shavit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202145907.GT1455070@nvidia.com \
--to=jgg@nvidia.com \
--cc=dan.carpenter@linaro.org \
--cc=iommu@lists.linux.dev \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox