From: Jason Gunthorpe <jgg@ziepe.ca>
To: Vasant Hegde <vasant.hegde@amd.com>
Cc: iommu@lists.linux.dev, joro@8bytes.org,
suravee.suthikulpanit@amd.com, alexander.deucher@amd.com,
Eric Wagner <ewagner12@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
stable@kernel.org
Subject: Re: [PATCH] iommu/amd: Enhance def_domain_type to handle untrusted device
Date: Fri, 19 Apr 2024 09:12:10 -0300 [thread overview]
Message-ID: <20240419121210.GA223006@ziepe.ca> (raw)
In-Reply-To: <20240419114715.6028-1-vasant.hegde@amd.com>
On Fri, Apr 19, 2024 at 11:47:15AM +0000, Vasant Hegde wrote:
> Previously, IOMMU core layer was forcing IOMMU_DOMAIN_DMA domain for
> untrusted device. This always took precedence over driver's
> def_domain_type(). Commit 59ddce4418da ("iommu: Reorganize
> iommu_get_default_domain_type() to respect def_domain_type()") changed
> the behaviour. Current code calls def_domain_type() but if it doesn't
> return IOMMU_DOMAIN_DMA for untrusted device it throws error. This
> results in IOMMU group (and potentially IOMMU itself) in undetermined
> sstate.
>
> This patch adds untrusted check in AMD IOMMU driver code. So that it
> lets eGPUs behind Thunderbolt work again.
>
> Fine tuning amd_iommu_def_domain_type() will be done later.
As long as this is done, and with the commitment that identity rid
with pasid will be eventually supported as well
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2024-04-19 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 11:47 [PATCH] iommu/amd: Enhance def_domain_type to handle untrusted device Vasant Hegde
2024-04-19 12:12 ` Jason Gunthorpe [this message]
2024-04-19 15:24 ` Deucher, Alexander
2024-04-23 10:11 ` Vasant Hegde
2024-04-19 18:14 ` Eric Wagner
2024-04-21 1:45 ` Baolu Lu
2024-04-23 10:10 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419121210.GA223006@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alexander.deucher@amd.com \
--cc=ewagner12@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=robin.murphy@arm.com \
--cc=stable@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox