From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABBD7142624 for ; Tue, 23 Apr 2024 17:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713893813; cv=none; b=fwwgheHt7TrGKRHRMdM5jxJqf/5zgpg/wVSbkpro06WOpwsfVWaub83pgQNccRf1xQkk5vCQj/6yVF3E+qG0AXFSSmwk3FocZToOjYp1nVygGDyhHUn1T/0zndyNy593jbQLcKV2eFU90MzA/Kv7kByyzvc58/DReH5ucC4yXpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713893813; c=relaxed/simple; bh=vHveCBoYcLQh8NROkIMdspOYAm2kEY1xSagTRG3zNfk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hO4NkxVFKUzX1ln9Sgt1tVrcoObDz+PXIJvn8ctnrjoTLdDI/Nm6ncAfcToeNi6KQ0RErZQEXIW0LoO/MDTiOh/11Vqho/FspB0WJ/c4ow3UoWORm77P56FfU66xYpYu1A3YsA03Q9NniLUtGnKIh+QaOr8EsLECNhWQXClnios= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QFGJNcIE; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QFGJNcIE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713893812; x=1745429812; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vHveCBoYcLQh8NROkIMdspOYAm2kEY1xSagTRG3zNfk=; b=QFGJNcIE2Tg7qgZf6FzsMXBNBvKsTyabkAvgrTYPaYkRo9NsUr7AgyhT suetCeiFW40konH1+BWcgtiTr/zbwPCBDxE0uOGlH3YOcbKBuq5+/pImI fmsYO8BBpeUsuLKLQXM4gHjtMEwq+KMC/mMm8MiTJ+svPmgxwL4SVMp1G 5RxyMIoLi7HcmWpWMMDkYEOGVSeaP2NqjUhSjmJtMcAa/qhCIwVvIKl0i 8UpS+ArqDldN2I3tMo6pclFsJ7s6+7PSL8y8I66fyJfD15UPCxnaTjJck tqVkYFi+DJF+VKHu8zmsfBzC19xIyu2OU3o7zM+aMxSmESETAQzm5YTBx A==; X-CSE-ConnectionGUID: Yx7qjfLoTaq7OHoZYp2RXg== X-CSE-MsgGUID: FgQT3lyQTqiddAE2HlNCGQ== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="9712422" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="9712422" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 10:36:44 -0700 X-CSE-ConnectionGUID: 6813K98VTTKaYFVGkrcS0w== X-CSE-MsgGUID: jJuW4cXiQbOaxBaDu9DBsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="29097428" Received: from jacob-builder.jf.intel.com ([10.54.39.125]) by fmviesa004.fm.intel.com with ESMTP; 23 Apr 2024 10:36:43 -0700 From: Jacob Pan To: LKML , X86 Kernel , Peter Zijlstra , iommu@lists.linux.dev, Thomas Gleixner , "Lu Baolu" , kvm@vger.kernel.org, Dave Hansen , Joerg Roedel , "H. Peter Anvin" , "Borislav Petkov" , "Ingo Molnar" Cc: Paul Luse , Dan Williams , Jens Axboe , Raj Ashok , "Tian, Kevin" , maz@kernel.org, seanjc@google.com, "Robin Murphy" , jim.harris@samsung.com, a.manzanares@samsung.com, "Bjorn Helgaas" , guang.zeng@intel.com, robert.hoo.linux@gmail.com, oliver.sang@intel.com, acme@kernel.org, Jacob Pan Subject: [PATCH v3 07/12] x86/irq: Factor out calling ISR from common_interrupt Date: Tue, 23 Apr 2024 10:41:09 -0700 Message-Id: <20240423174114.526704-8-jacob.jun.pan@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240423174114.526704-1-jacob.jun.pan@linux.intel.com> References: <20240423174114.526704-1-jacob.jun.pan@linux.intel.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Prepare for calling external IRQ handlers directly from the posted MSI demultiplexing loop. Extract the common code with common interrupt to avoid code duplication. Signed-off-by: Jacob Pan --- arch/x86/kernel/irq.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index dbb3a19b3004..d652b0481899 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -242,18 +242,10 @@ static __always_inline void handle_irq(struct irq_desc *desc, __handle_irq(desc, regs); } -/* - * common_interrupt() handles all normal device IRQ's (the special SMP - * cross-CPU interrupts have their own entry points). - */ -DEFINE_IDTENTRY_IRQ(common_interrupt) +static __always_inline void call_irq_handler(int vector, struct pt_regs *regs) { - struct pt_regs *old_regs = set_irq_regs(regs); struct irq_desc *desc; - /* entry code tells RCU that we're not quiescent. Check it. */ - RCU_LOCKDEP_WARN(!rcu_is_watching(), "IRQ failed to wake up RCU"); - desc = __this_cpu_read(vector_irq[vector]); if (likely(!IS_ERR_OR_NULL(desc))) { handle_irq(desc, regs); @@ -268,7 +260,20 @@ DEFINE_IDTENTRY_IRQ(common_interrupt) __this_cpu_write(vector_irq[vector], VECTOR_UNUSED); } } +} + +/* + * common_interrupt() handles all normal device IRQ's (the special SMP + * cross-CPU interrupts have their own entry points). + */ +DEFINE_IDTENTRY_IRQ(common_interrupt) +{ + struct pt_regs *old_regs = set_irq_regs(regs); + + /* entry code tells RCU that we're not quiescent. Check it. */ + RCU_LOCKDEP_WARN(!rcu_is_watching(), "IRQ failed to wake up RCU"); + call_irq_handler(vector, regs); set_irq_regs(old_regs); } -- 2.25.1