From: Jason Gunthorpe <jgg@ziepe.ca>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iommu/vt-d: Fix missed device TLB cache tag
Date: Wed, 19 Jun 2024 13:46:20 -0300 [thread overview]
Message-ID: <20240619164620.GN791043@ziepe.ca> (raw)
In-Reply-To: <20240619015345.182773-1-baolu.lu@linux.intel.com>
On Wed, Jun 19, 2024 at 09:53:45AM +0800, Lu Baolu wrote:
> When a domain is attached to a device, the required cache tags are
> assigned to the domain so that the related caches could be flushed
> whenever it is needed. The device TLB cache tag is created selectively
> by checking the ats_enabled field of the device's iommu data. This
> creates an ordered dependency between attach and ATS enabling paths.
>
> The device TLB cache tag will not be created if device's ATS is enabled
> after the domain attachment. This causes some devices, for example
> intel_vpu, to malfunction.
What? How is this even possible?
ATS is controlled exclusively by the iommu driver, how can it be
changed without the driver knowing??
Jason
next prev parent reply other threads:[~2024-06-19 16:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 1:53 [PATCH 1/1] iommu/vt-d: Fix missed device TLB cache tag Lu Baolu
2024-06-19 16:46 ` Jason Gunthorpe [this message]
2024-06-20 0:50 ` Baolu Lu
2024-06-20 3:04 ` Tian, Kevin
2024-06-20 3:13 ` Baolu Lu
2024-06-20 3:57 ` Tian, Kevin
2024-06-20 6:04 ` Baolu Lu
2024-06-20 5:54 ` Vasant Hegde
2024-06-20 6:27 ` Baolu Lu
2024-06-20 10:49 ` Vasant Hegde
2024-06-20 14:08 ` Jason Gunthorpe
2024-06-21 1:44 ` Baolu Lu
2024-06-21 12:58 ` Jason Gunthorpe
2024-06-24 14:26 ` Vasant Hegde
2024-06-24 16:12 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619164620.GN791043@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox