From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 759472A1D1 for ; Wed, 10 Jul 2024 08:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720600598; cv=none; b=uKGsLX2sAZsVkNdYchnzkjHisuVx0DLK1eW58h/bt3xdBWQLZrFAk9mJ/Ln5Cs4AkaRN/ZBEqUzuoOaM4d34L6bKyjLHc0ZMGBWhbMEzCP0LoCVv/lPrIr4GHeueV9hf8S81GvEWhNFu1hiXemyhSIMk9YpQcYDlnQWTfbgPHKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720600598; c=relaxed/simple; bh=evQLV0pO07i+iE+j9o5IcO3BTGx5gXIQVZCSP53bD4c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g9Kt7ynI66Lmo/9rorJRb7YxShqg6NiW3m0x+PKbybqLrajrnfRKdRpHcUhd9XRaQpHWT/uQPp+qZEUQLotD+ahHljZfgQGqGFOBF2HUwHliQTwl2OGpAnuuk7GQC/nlm+m5HCy/InRm3JsULd3TnFnXPEIbnoBe3AxMmEuBUXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jg97+jRu; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jg97+jRu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720600597; x=1752136597; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=evQLV0pO07i+iE+j9o5IcO3BTGx5gXIQVZCSP53bD4c=; b=jg97+jRu7DtVBLmVrRzKbOq67N/xU8OaKtx3KH4nOyRVakt2U+Cq5o6c +WjD9qEkkBLY92usMKs1x1NQ5zy/9lgCkpkIjgRCIN+4dqHpHYw4CtYoM 2McZwDxt4uCimOyyr+Apt75i36JUSO3oWH0IlqrXXgzDw0reosOdaeC8r 5iFe9JJNeS4va+m0XuYvPKKGie21tjbiy47oYCkEIg6KsjulfuFEUm0MY aWYxvh+hZcMTl6/UbTDUGtJYyVp8iGlFPw8/+PsZ8FYhSKcqnb3GDKfm6 JppWaD7sG7dZORvPB1EHOlpJj1xHNQuC9b7QKbfLENdZXCBjY0KHLC07t Q==; X-CSE-ConnectionGUID: u1nFAd8LSm+zTrStLyMXfg== X-CSE-MsgGUID: sUaNhQOPRfaKLLKIogfvgw== X-IronPort-AV: E=McAfee;i="6700,10204,11128"; a="17770966" X-IronPort-AV: E=Sophos;i="6.09,197,1716274800"; d="scan'208";a="17770966" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2024 01:36:37 -0700 X-CSE-ConnectionGUID: VbKz419FR6GpZFxj3Xqo7Q== X-CSE-MsgGUID: P3YDkvMtSiSWQygHyqEpHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,197,1716274800"; d="scan'208";a="48236135" Received: from unknown (HELO allen-box.sh.intel.com) ([10.239.159.127]) by fmviesa010.fm.intel.com with ESMTP; 10 Jul 2024 01:36:35 -0700 From: Lu Baolu To: Jason Gunthorpe , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Nicolin Chen , Yi Liu Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Lu Baolu Subject: [PATCH 1/3] iommufd: Remove IOMMUFD_PAGE_RESP_FAILURE Date: Wed, 10 Jul 2024 16:33:39 +0800 Message-Id: <20240710083341.44617-2-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240710083341.44617-1-baolu.lu@linux.intel.com> References: <20240710083341.44617-1-baolu.lu@linux.intel.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The response code of IOMMUFD_PAGE_RESP_FAILURE was defined to be equivalent to the "Response Failure" in PCI spec, section 10.4.2.1. This response code indicates that one or more pages within the associated request group have encountered or caused an unrecoverable error. Therefore, this response disables the PRI at the function. Modern I/O virtualization technologies, like SR-IOV, share PRI among the assignable device units. Therefore, a response failure on one unit might cause I/O failure on other units. Remove this response code so that user space can only respond with SUCCESS or INVALID. The VMM is recommended to emulate a failure response as a PRI reset, or PRI disable and changing to a non-PRI domain. Fixes: c714f15860fc ("iommufd: Add fault and response message definitions") Signed-off-by: Lu Baolu --- include/uapi/linux/iommufd.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h index ede2b464a761..e31385b75d0b 100644 --- a/include/uapi/linux/iommufd.h +++ b/include/uapi/linux/iommufd.h @@ -765,14 +765,10 @@ struct iommu_hwpt_pgfault { * @IOMMUFD_PAGE_RESP_INVALID: Could not handle this fault, don't retry the * access. This is the "Invalid Request" in PCI * 10.4.2.1. - * @IOMMUFD_PAGE_RESP_FAILURE: General error. Drop all subsequent faults from - * this device if possible. This is the "Response - * Failure" in PCI 10.4.2.1. */ enum iommufd_page_response_code { IOMMUFD_PAGE_RESP_SUCCESS = 0, IOMMUFD_PAGE_RESP_INVALID, - IOMMUFD_PAGE_RESP_FAILURE, }; /** -- 2.34.1