From: Vasant Hegde <vasant.hegde@amd.com>
To: <iommu@lists.linux.dev>, <joro@8bytes.org>
Cc: <will@kernel.org>, <robin.murphy@arm.com>,
<suravee.suthikulpanit@amd.com>,
Vasant Hegde <vasant.hegde@amd.com>
Subject: [PATCH 4/8] iommu/amd: Handle error path in amd_iommu_probe_device()
Date: Wed, 28 Aug 2024 11:10:25 +0000 [thread overview]
Message-ID: <20240828111029.5429-5-vasant.hegde@amd.com> (raw)
In-Reply-To: <20240828111029.5429-1-vasant.hegde@amd.com>
Do not try to set max_pasids in error path as dev_data is not allocated.
Fixes: a0c47f233e68 ("iommu/amd: Introduce iommu_dev_data.max_pasids")
Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
---
drivers/iommu/amd/iommu.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index c57ea47183c3..be31a263ac6f 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -2187,11 +2187,12 @@ static struct iommu_device *amd_iommu_probe_device(struct device *dev)
dev_err(dev, "Failed to initialize - trying to proceed anyway\n");
iommu_dev = ERR_PTR(ret);
iommu_ignore_device(iommu, dev);
- } else {
- amd_iommu_set_pci_msi_domain(dev, iommu);
- iommu_dev = &iommu->iommu;
+ goto out_err;
}
+ amd_iommu_set_pci_msi_domain(dev, iommu);
+ iommu_dev = &iommu->iommu;
+
/*
* If IOMMU and device supports PASID then it will contain max
* supported PASIDs, else it will be zero.
@@ -2203,11 +2204,12 @@ static struct iommu_device *amd_iommu_probe_device(struct device *dev)
pci_max_pasids(to_pci_dev(dev)));
}
- iommu_completion_wait(iommu);
-
if (dev_is_pci(dev))
pci_prepare_ats(to_pci_dev(dev), PAGE_SHIFT);
+out_err:
+ iommu_completion_wait(iommu);
+
return iommu_dev;
}
--
2.31.1
next prev parent reply other threads:[~2024-08-28 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 11:10 [PATCH 0/8] iommu/amd: Misc cleanup and trivial fixes Vasant Hegde
2024-08-28 11:10 ` [PATCH 1/8] iommu/amd: Update event log pointer as soon as processing is complete Vasant Hegde
2024-08-28 11:10 ` [PATCH 2/8] iommu/amd: Make amd_iommu_is_attach_deferred() static Vasant Hegde
2024-08-28 11:10 ` [PATCH 3/8] iommu/amd: Remove unused DTE_GCR3_INDEX_* macros Vasant Hegde
2024-08-28 11:10 ` Vasant Hegde [this message]
2024-08-28 11:10 ` [PATCH 5/8] iommu/amd: Make amd_iommu_dev_flush_pasid_all() static Vasant Hegde
2024-08-28 11:10 ` [PATCH 6/8] iommu/amd: Make amd_iommu_domain_flush_complete() static Vasant Hegde
2024-08-28 11:10 ` [PATCH 7/8] iommu/amd: Rework amd_iommu_update_and_flush_device_table() Vasant Hegde
2024-08-28 11:10 ` [PATCH 8/8] iommu/amd: Make amd_iommu_dev_update_dte() static Vasant Hegde
2024-09-04 9:36 ` [PATCH 0/8] iommu/amd: Misc cleanup and trivial fixes Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828111029.5429-5-vasant.hegde@amd.com \
--to=vasant.hegde@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).