Re: [PATCH 1/2] dma-mapping: fix vmap and mmap of noncontiougs allocations

[Leon Romanovsky <leon@kernel.org>]

On Sun, Sep 22, 2024 at 04:07:34PM +0200, Christoph Hellwig wrote:
> Commit b5c58b2fdc42 ("dma-mapping: direct calls for dma-iommu") switched
> to use direct calls to dma-iommu, but missed the dma_vmap_noncontiguous,
> dma_vunmap_noncontiguous and dma_mmap_noncontiguous behavior keyed off the
> presence of the alloc_noncontiguous method.
> 
> Fix this by removing the now unused alloc_noncontiguous and
> free_noncontiguous methods and moving the vmapping and mmaping of the
> noncontiguous allocations into the iommu code, as it is the only provider
> of actually noncontiguous allocations.
> 
> Fixes: b5c58b2fdc42 ("dma-mapping: direct calls for dma-iommu")
> Reported-by: Xi Ruoyao <xry111@xry111.site>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Tested-by: Xi Ruoyao <xry111@xry111.site>
> ---
>  drivers/iommu/dma-iommu.c   | 33 +++++++++++++++++++++++++++++++++
>  include/linux/dma-map-ops.h | 19 -------------------
>  include/linux/iommu-dma.h   |  6 ++++++
>  kernel/dma/mapping.c        | 37 ++++++++++---------------------------
>  4 files changed, 49 insertions(+), 46 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leon@kernel.org>