From: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
To: <joro@8bytes.org>, <suravee.suthikulpanit@amd.com>,
<will@kernel.org>, <robin.murphy@arm.com>,
<dheerajkumar.srivastava@amd.com>, <linux-kernel@vger.kernel.org>,
<iommu@lists.linux.dev>
Subject: [PATCH 2/8] iommu/amd: Add debugfs support to dump IOMMU MMIO registers
Date: Tue, 8 Oct 2024 16:10:29 +0530 [thread overview]
Message-ID: <20241008104035.4008-3-dheerajkumar.srivastava@amd.com> (raw)
In-Reply-To: <20241008104035.4008-1-dheerajkumar.srivastava@amd.com>
Analyzing IOMMU MMIO registers gives a view of what IOMMU is
configured with on the system and is helpful to debug issues
with IOMMU.
eg.
1. To get mmio registers value for iommu<x>
# echo "0x18" > /sys/kernel/debug/iommu/amd/iommu00/mmio
# cat /sys/kernel/debug/iommu/amd/iommu00/mmio_dump
Signed-off-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>
---
drivers/iommu/amd/debugfs.c | 75 +++++++++++++++++++++++++++++++++++++
1 file changed, 75 insertions(+)
diff --git a/drivers/iommu/amd/debugfs.c b/drivers/iommu/amd/debugfs.c
index ff9520e002be..30d6819e9a35 100644
--- a/drivers/iommu/amd/debugfs.c
+++ b/drivers/iommu/amd/debugfs.c
@@ -15,6 +15,76 @@
static struct dentry *amd_iommu_debugfs;
#define MAX_NAME_LEN 20
+#define OFS_IN_SZ 8
+
+static int mmio_offset = -1;
+
+static ssize_t iommu_mmio_write(struct file *filp, const char __user *ubuf,
+ size_t cnt, loff_t *ppos)
+{
+ struct seq_file *m = filp->private_data;
+ struct amd_iommu *iommu = m->private;
+ char *mmio_ptr_ofs;
+ int ret = cnt;
+
+ if (cnt > OFS_IN_SZ) {
+ ret = -EINVAL;
+ goto err;
+ }
+
+ mmio_ptr_ofs = memdup_user_nul(ubuf, cnt);
+ if (IS_ERR(mmio_ptr_ofs)) {
+ ret = PTR_ERR(mmio_ptr_ofs);
+ goto err;
+ }
+
+ if (kstrtou32(mmio_ptr_ofs, 0, &mmio_offset) < 0) {
+ ret = -EINVAL;
+ goto free;
+ }
+
+ if (mmio_offset > iommu->mmio_phys_end - 4) {
+ ret = -EINVAL;
+ goto free;
+ }
+
+ kfree(mmio_ptr_ofs);
+ *ppos += cnt;
+ return ret;
+
+free:
+ kfree(mmio_ptr_ofs);
+err:
+ mmio_offset = -1;
+ return ret;
+}
+
+static int iommu_mmio_show(struct seq_file *m, void *unused)
+{
+ if (mmio_offset >= 0)
+ seq_printf(m, "0x%x\n", mmio_offset);
+ else
+ seq_puts(m, "No or invalid input provided\n");
+ return 0;
+}
+DEFINE_SHOW_STORE_ATTRIBUTE(iommu_mmio);
+
+static int iommu_mmio_dump_show(struct seq_file *m, void *unused)
+{
+ struct amd_iommu *iommu = m->private;
+ u32 value;
+
+ if (mmio_offset < 0) {
+ seq_puts(m, "Please provide mmio register's offset\n");
+ return 0;
+ }
+
+ value = readl(iommu->mmio_base + mmio_offset);
+ seq_printf(m, "0x%08x\n", value);
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(iommu_mmio_dump);
void amd_iommu_debugfs_setup(void)
{
@@ -26,5 +96,10 @@ void amd_iommu_debugfs_setup(void)
for_each_iommu(iommu) {
snprintf(name, MAX_NAME_LEN, "iommu%02d", iommu->index);
iommu->debugfs = debugfs_create_dir(name, amd_iommu_debugfs);
+
+ debugfs_create_file("mmio", 0644, iommu->debugfs, iommu,
+ &iommu_mmio_fops);
+ debugfs_create_file("mmio_dump", 0444, iommu->debugfs, iommu,
+ &iommu_mmio_dump_fops);
}
}
--
2.25.1
next prev parent reply other threads:[~2024-10-08 10:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 10:40 [PATCH 0/8] Introduce debugfs support in IOMMU Dheeraj Kumar Srivastava
2024-10-08 10:40 ` [PATCH 1/8] iommu/amd: Refactor AMD IOMMU debugfs initial setup Dheeraj Kumar Srivastava
2024-10-08 10:40 ` Dheeraj Kumar Srivastava [this message]
2024-10-08 10:40 ` [PATCH 3/8] iommu/amd: Add debugfs support to dump IOMMU Capability registers Dheeraj Kumar Srivastava
2024-10-08 10:40 ` [PATCH 4/8] iommu/amd: Add debugfs support to dump IOMMU command buffer Dheeraj Kumar Srivastava
2024-10-08 10:40 ` [PATCH 5/8] iommu/amd: Add support for device id user input Dheeraj Kumar Srivastava
2024-10-08 10:40 ` [PATCH 6/8] iommu/amd: Add debugfs support to dump device table Dheeraj Kumar Srivastava
2024-10-08 10:40 ` [PATCH 7/8] iommu/amd: Add debugfs support to dump IRT Table Dheeraj Kumar Srivastava
2024-10-08 10:40 ` [PATCH 8/8] iommu/amd: Add documentation for AMD IOMMU debugfs support Dheeraj Kumar Srivastava
2024-10-09 1:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008104035.4008-3-dheerajkumar.srivastava@amd.com \
--to=dheerajkumar.srivastava@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox