Re: [PATCH v3 05/10] iommu/amd: Do not detach devices in domain free path

[Jason Gunthorpe <jgg@ziepe.ca>]

On Wed, Oct 16, 2024 at 05:34:56AM +0000, Vasant Hegde wrote:
> All devices attached to a protection domain must be freed before
> calling domain free. Hence do not try to free devices in domain
> free path. Continue to throw warning if pdom->dev_list is not empty
> so that any potential issues can be fixed.
> 
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> Reviewed-by: Joerg Roedel <jroedel@suse.de>
> ---
>  drivers/iommu/amd/iommu.c | 26 +-------------------------
>  1 file changed, 1 insertion(+), 25 deletions(-)

Yes!

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

>  void protection_domain_free(struct protection_domain *domain)
>  {
>  	WARN_ON(!list_empty(&domain->dev_list));

Probably should also check that the new xarray is empty here too??
Otherwise it will leak struct pdom_iommu_info memory.

Jason