From: Vasant Hegde <vasant.hegde@amd.com>
To: <iommu@lists.linux.dev>, <joro@8bytes.org>
Cc: <will@kernel.org>, <robin.murphy@arm.com>,
<suravee.suthikulpanit@amd.com>, <jgg@ziepe.ca>,
<yi.l.liu@intel.com>, <baolu.lu@linux.intel.com>,
<kevin.tian@intel.com>, <jacob.pan@linux.microsoft.com>,
Vasant Hegde <vasant.hegde@amd.com>,
"Jason Gunthorpe" <jgg@nvidia.com>
Subject: [PATCH v4 05/12] iommu/amd: Add helper function to check GIOSUP/GTSUP
Date: Wed, 23 Oct 2024 10:42:00 +0000 [thread overview]
Message-ID: <20241023104207.5894-6-vasant.hegde@amd.com> (raw)
In-Reply-To: <20241023104207.5894-1-vasant.hegde@amd.com>
amd_iommu_gt_ppr_supported() only checks for GTSUP. To support PASID
with V2 page table we need GIOSUP as well. Hence add new helper function
to check GIOSUP/GTSUP.
Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
drivers/iommu/amd/amd_iommu.h | 7 ++++++-
drivers/iommu/amd/init.c | 3 +--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/iommu/amd/amd_iommu.h b/drivers/iommu/amd/amd_iommu.h
index 6386fa4556d9..3b6c6332b09f 100644
--- a/drivers/iommu/amd/amd_iommu.h
+++ b/drivers/iommu/amd/amd_iommu.h
@@ -118,9 +118,14 @@ static inline bool check_feature2(u64 mask)
return (amd_iommu_efr2 & mask);
}
+static inline bool amd_iommu_v2_pgtbl_supported(void)
+{
+ return (check_feature(FEATURE_GIOSUP) && check_feature(FEATURE_GT));
+}
+
static inline bool amd_iommu_gt_ppr_supported(void)
{
- return (check_feature(FEATURE_GT) &&
+ return (amd_iommu_v2_pgtbl_supported() &&
check_feature(FEATURE_PPR) &&
check_feature(FEATURE_EPHSUP));
}
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index 43131c3a2172..7ae478d95e2b 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -2071,8 +2071,7 @@ static int __init iommu_init_pci(struct amd_iommu *iommu)
init_iommu_perf_ctr(iommu);
if (amd_iommu_pgtable == AMD_IOMMU_V2) {
- if (!check_feature(FEATURE_GIOSUP) ||
- !check_feature(FEATURE_GT)) {
+ if (!amd_iommu_v2_pgtbl_supported()) {
pr_warn("Cannot enable v2 page table for DMA-API. Fallback to v1.\n");
amd_iommu_pgtable = AMD_IOMMU_V1;
}
--
2.31.1
next prev parent reply other threads:[~2024-10-23 10:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 10:41 [PATCH v4 00/12] iommu: Domain allocation enhancements Vasant Hegde
2024-10-23 10:41 ` [PATCH v4 01/12] iommu: Refactor __iommu_domain_alloc() Vasant Hegde
2024-10-23 10:41 ` [PATCH v4 02/12] iommu: Introduce iommu_paging_domain_alloc_flags() Vasant Hegde
2024-10-23 14:26 ` Robin Murphy
2024-10-23 14:44 ` Jason Gunthorpe
2024-10-25 8:22 ` Tian, Kevin
2024-10-23 10:41 ` [PATCH v4 03/12] iommu: Add new flag to explictly request PASID capable domain Vasant Hegde
2024-10-23 11:11 ` Baolu Lu
2024-10-25 8:23 ` Tian, Kevin
2024-10-23 10:41 ` [PATCH v4 04/12] iommu/arm-smmu-v3: Enhance domain_alloc_user() to allocate " Vasant Hegde
2024-10-23 12:23 ` Jason Gunthorpe
2024-10-25 8:23 ` Tian, Kevin
2024-10-23 10:42 ` Vasant Hegde [this message]
2024-10-23 10:42 ` [PATCH v4 06/12] iommu/amd: Move V2 page table support check to early_amd_iommu_init() Vasant Hegde
2024-10-23 10:42 ` [PATCH v4 07/12] iommu/amd: Separate page table setup from domain allocation Vasant Hegde
2024-10-23 10:42 ` [PATCH v4 08/12] iommu/amd: Pass page table type as param to pdom_setup_pgtable() Vasant Hegde
2024-10-23 10:42 ` [PATCH v4 09/12] iommu/amd: Enhance amd_iommu_domain_alloc_user() Vasant Hegde
2024-10-23 12:46 ` Jason Gunthorpe
2024-10-24 6:38 ` Vasant Hegde
2024-10-25 8:24 ` Tian, Kevin
2024-10-23 10:42 ` [PATCH v4 10/12] iommu/amd: Implement global identity domain Vasant Hegde
2024-10-25 8:24 ` Tian, Kevin
2024-10-23 10:42 ` [PATCH v4 11/12] iommu: Put domain allocation in __iommu_group_alloc_blocking_domain() Vasant Hegde
2024-10-25 8:25 ` Tian, Kevin
2024-10-23 10:42 ` [PATCH v4 12/12] iommu: Create __iommu_alloc_identity_domain() Vasant Hegde
2024-10-25 8:25 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023104207.5894-6-vasant.hegde@amd.com \
--to=vasant.hegde@amd.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox