From: Jason Gunthorpe <jgg@ziepe.ca>
To: Vasant Hegde <vasant.hegde@amd.com>
Cc: iommu@lists.linux.dev, joro@8bytes.org, will@kernel.org,
robin.murphy@arm.com, suravee.suthikulpanit@amd.com
Subject: Re: [PATCH v4 01/12] iommu/amd/pgtbl_v2: Take protection domain lock before invalidating TLB
Date: Mon, 28 Oct 2024 12:26:04 -0300 [thread overview]
Message-ID: <20241028152604.GC20281@ziepe.ca> (raw)
In-Reply-To: <20241028113148.5774-2-vasant.hegde@amd.com>
On Mon, Oct 28, 2024 at 11:31:37AM +0000, Vasant Hegde wrote:
> Commit c7fc12354be0 ("iommu/amd/pgtbl_v2: Invalidate updated page ranges
> only") missed to take domain lock before calling
> amd_iommu_domain_flush_pages(). Fix this by taking protection domain
> lock before calling TLB invalidation function.
>
> Fixes: c7fc12354be0 ("iommu/amd/pgtbl_v2: Invalidate updated page ranges only")
> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
> ---
> drivers/iommu/amd/io_pgtable_v2.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2024-10-28 15:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 11:31 [PATCH v4 00/12] iommu/amd: Improve domain allocator and device attach code path Vasant Hegde
2024-10-28 11:31 ` [PATCH v4 01/12] iommu/amd/pgtbl_v2: Take protection domain lock before invalidating TLB Vasant Hegde
2024-10-28 15:26 ` Jason Gunthorpe [this message]
2024-10-28 11:31 ` [PATCH v4 02/12] iommu/amd: Use ida interface to manage protection domain ID Vasant Hegde
2024-10-28 15:27 ` Jason Gunthorpe
2024-10-28 11:31 ` [PATCH v4 03/12] iommu/amd: Remove protection_domain.dev_cnt variable Vasant Hegde
2024-10-28 11:31 ` [PATCH v4 04/12] iommu/amd: xarray to track protection_domain->iommu list Vasant Hegde
2024-10-28 11:31 ` [PATCH v4 05/12] iommu/amd: Remove unused amd_iommus variable Vasant Hegde
2024-10-28 11:31 ` [PATCH v4 06/12] iommu/amd: Do not detach devices in domain free path Vasant Hegde
2024-10-28 11:31 ` [PATCH v4 07/12] iommu/amd: Reduce domain lock scope in attach device path Vasant Hegde
2024-10-28 15:34 ` Jason Gunthorpe
2024-10-28 11:31 ` [PATCH v4 08/12] iommu/amd: Rearrange attach device code Vasant Hegde
2024-10-28 11:31 ` [PATCH v4 09/12] iommu/amd: Convert dev_data lock from spinlock to mutex Vasant Hegde
2024-10-28 11:31 ` [PATCH v4 10/12] iommu/amd: Reorder attach device code Vasant Hegde
2024-10-28 11:31 ` [PATCH v4 11/12] iommu/amd: Add opa->release_domain Vasant Hegde
2024-10-28 15:35 ` Jason Gunthorpe
2024-10-28 11:31 ` [PATCH v4 12/12] iommu/amd: Improve amd_iommu_release_device() Vasant Hegde
2024-10-28 15:40 ` Jason Gunthorpe
2024-10-29 9:14 ` [PATCH v4 00/12] iommu/amd: Improve domain allocator and device attach code path Joerg Roedel
2024-10-29 10:15 ` Joerg Roedel
2024-10-29 16:36 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028152604.GC20281@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox