From: Vasant Hegde <vasant.hegde@amd.com>
To: <iommu@lists.linux.dev>, <joro@8bytes.org>
Cc: <will@kernel.org>, <robin.murphy@arm.com>,
<suravee.suthikulpanit@amd.com>, <jgg@ziepe.ca>,
Vasant Hegde <vasant.hegde@amd.com>,
Jason Gunthorpe <jgg@nvidia.com>
Subject: [PATCH v5 01/12] iommu/amd/pgtbl_v2: Take protection domain lock before invalidating TLB
Date: Wed, 30 Oct 2024 06:35:45 +0000 [thread overview]
Message-ID: <20241030063556.6104-2-vasant.hegde@amd.com> (raw)
In-Reply-To: <20241030063556.6104-1-vasant.hegde@amd.com>
Commit c7fc12354be0 ("iommu/amd/pgtbl_v2: Invalidate updated page ranges
only") missed to take domain lock before calling
amd_iommu_domain_flush_pages(). Fix this by taking protection domain
lock before calling TLB invalidation function.
Fixes: c7fc12354be0 ("iommu/amd/pgtbl_v2: Invalidate updated page ranges only")
Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
drivers/iommu/amd/io_pgtable_v2.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/iommu/amd/io_pgtable_v2.c b/drivers/iommu/amd/io_pgtable_v2.c
index 25b9042fa453..c616de2c5926 100644
--- a/drivers/iommu/amd/io_pgtable_v2.c
+++ b/drivers/iommu/amd/io_pgtable_v2.c
@@ -268,8 +268,11 @@ static int iommu_v2_map_pages(struct io_pgtable_ops *ops, unsigned long iova,
out:
if (updated) {
struct protection_domain *pdom = io_pgtable_ops_to_domain(ops);
+ unsigned long flags;
+ spin_lock_irqsave(&pdom->lock, flags);
amd_iommu_domain_flush_pages(pdom, o_iova, size);
+ spin_unlock_irqrestore(&pdom->lock, flags);
}
if (mapped)
--
2.31.1
next prev parent reply other threads:[~2024-10-30 6:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 6:35 [PATCH v5 00/12] iommu/amd: Improve domain allocator and device attach code path Vasant Hegde
2024-10-30 6:35 ` Vasant Hegde [this message]
2024-10-30 6:35 ` [PATCH v5 02/12] iommu/amd: Use ida interface to manage protection domain ID Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 03/12] iommu/amd: Remove protection_domain.dev_cnt variable Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 04/12] iommu/amd: xarray to track protection_domain->iommu list Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 05/12] iommu/amd: Remove unused amd_iommus variable Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 06/12] iommu/amd: Do not detach devices in domain free path Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 07/12] iommu/amd: Reduce domain lock scope in attach device path Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 08/12] iommu/amd: Rearrange attach device code Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 09/12] iommu/amd: Convert dev_data lock from spinlock to mutex Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 10/12] iommu/amd: Reorder attach device code Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 11/12] iommu/amd: Add ops->release_domain Vasant Hegde
2024-10-30 6:35 ` [PATCH v5 12/12] iommu/amd: Improve amd_iommu_release_device() Vasant Hegde
2024-10-30 10:24 ` [PATCH v5 00/12] iommu/amd: Improve domain allocator and device attach code path Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030063556.6104-2-vasant.hegde@amd.com \
--to=vasant.hegde@amd.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox