From: Yi Liu <yi.l.liu@intel.com>
To: joro@8bytes.org, jgg@nvidia.com, kevin.tian@intel.com,
baolu.lu@linux.intel.com
Cc: alex.williamson@redhat.com, eric.auger@redhat.com,
nicolinc@nvidia.com, kvm@vger.kernel.org,
chao.p.peng@linux.intel.com, yi.l.liu@intel.com,
iommu@lists.linux.dev, zhenzhong.duan@intel.com,
vasant.hegde@amd.com, willy@infradead.org
Subject: [PATCH v6 08/13] iommu/vt-d: Limit intel_iommu_set_dev_pasid() for paging domain
Date: Thu, 7 Nov 2024 04:22:29 -0800 [thread overview]
Message-ID: <20241107122234.7424-9-yi.l.liu@intel.com> (raw)
In-Reply-To: <20241107122234.7424-1-yi.l.liu@intel.com>
intel_iommu_set_dev_pasid() is only supposed to be used by paging domain,
so limit it.
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
---
drivers/iommu/intel/iommu.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 6b7f48119502..3c1b92fa5877 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -4156,6 +4156,9 @@ static int intel_iommu_set_dev_pasid(struct iommu_domain *domain,
struct dev_pasid_info *dev_pasid;
int ret;
+ if (WARN_ON_ONCE(!(domain->type & __IOMMU_DOMAIN_PAGING)))
+ return -EINVAL;
+
if (!pasid_supported(iommu) || dev_is_real_dma_subdevice(dev))
return -EOPNOTSUPP;
@@ -4184,8 +4187,7 @@ static int intel_iommu_set_dev_pasid(struct iommu_domain *domain,
domain_remove_dev_pasid(old, dev, pasid);
- if (domain->type & __IOMMU_DOMAIN_PAGING)
- intel_iommu_debugfs_create_dev_pasid(dev_pasid);
+ intel_iommu_debugfs_create_dev_pasid(dev_pasid);
return 0;
--
2.34.1
next prev parent reply other threads:[~2024-11-07 12:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 12:22 [PATCH v6 00/13] Make set_dev_pasid op supporting domain replacement Yi Liu
2024-11-07 12:22 ` [PATCH v6 01/13] iommu: Pass old domain to set_dev_pasid op Yi Liu
2024-11-07 12:22 ` [PATCH v6 02/13] iommu/vt-d: Add a helper to flush cache for updating present pasid entry Yi Liu
2024-11-07 12:22 ` [PATCH v6 03/13] iommu/vt-d: Refactor the pasid setup helpers Yi Liu
2024-11-07 12:22 ` [PATCH v6 04/13] iommu/vt-d: Add pasid replace helpers Yi Liu
2024-11-07 12:22 ` [PATCH v6 05/13] iommu/vt-d: Consolidate the struct dev_pasid_info add/remove Yi Liu
2024-11-07 12:22 ` [PATCH v6 06/13] iommu/vt-d: Add iommu_domain_did() to get did Yi Liu
2024-11-07 12:22 ` [PATCH v6 07/13] iommu/vt-d: Make intel_iommu_set_dev_pasid() to handle domain replacement Yi Liu
2024-11-07 12:22 ` Yi Liu [this message]
2024-11-07 12:22 ` [PATCH v6 09/13] iommu/vt-d: Make intel_svm_set_dev_pasid() support " Yi Liu
2024-11-07 12:22 ` [PATCH v6 10/13] iommu/vt-d: Make identity_domain_set_dev_pasid() to handle " Yi Liu
2024-11-07 12:22 ` [PATCH v6 11/13] iommu/vt-d: Add set_dev_pasid callback for nested domain Yi Liu
2024-11-07 12:22 ` [PATCH v6 12/13] iommu/arm-smmu-v3: Make set_dev_pasid() op support replace Yi Liu
2024-11-07 12:22 ` [PATCH v6 13/13] iommu: Make set_dev_pasid op support domain replacement Yi Liu
2024-11-08 2:12 ` [PATCH v6 00/13] Make set_dev_pasid op supporting " Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107122234.7424-9-yi.l.liu@intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=vasant.hegde@amd.com \
--cc=willy@infradead.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox