Re: [PATCH V5 4/4] iommufd: IOMMU_IOAS_CHANGE_PROCESS selftest

[Jason Gunthorpe <jgg@nvidia.com>]

On Wed, Nov 13, 2024 at 11:51:37AM -0800, Steve Sistare wrote:
> Add selftest cases for IOMMU_IOAS_CHANGE_PROCESS.
> 
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  tools/testing/selftests/iommu/Makefile        |   1 +
>  tools/testing/selftests/iommu/iommufd.c       | 141 ++++++++++++++++++++++++++
>  tools/testing/selftests/iommu/iommufd_utils.h |   6 ++
>  3 files changed, 148 insertions(+)
> 
> diff --git a/tools/testing/selftests/iommu/Makefile b/tools/testing/selftests/iommu/Makefile
> index fd64779..bd23ac9 100644
> --- a/tools/testing/selftests/iommu/Makefile
> +++ b/tools/testing/selftests/iommu/Makefile
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  CFLAGS += -Wall -O2 -Wno-unused-function
>  CFLAGS += $(KHDR_INCLUDES)
> +CFLAGS += -lcap

This should be

LDLIBS += -lcap

Otherwise it doesn't compile:

iommufd.c:(.text+0xe54a): undefined reference to `cap_get_proc'
/usr/bin/ld: iommufd.c:(.text+0xe57a): undefined reference to `cap_set_flag'
/usr/bin/ld: iommufd.c:(.text+0xe596): undefined reference to `cap_set_proc'
/usr/bin/ld: iommufd.c:(.text+0xe5b5): undefined reference to `cap_free'

Because the -l option is in the wrong order

Jason