Linux IOMMU Development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Robin Murphy <robin.murphy@arm.com>
Cc: will@kernel.org, joro@8bytes.org, iommu@lists.linux.dev,
	yf.wang@mediatek.com
Subject: Re: [PATCH] iommu/dma: Remove redundant locking
Date: Wed, 5 Mar 2025 13:30:32 -0400	[thread overview]
Message-ID: <20250305173032.GH5011@ziepe.ca> (raw)
In-Reply-To: <a943d4c198e6a1fffe998337d577dc3aa7f660a9.1740585469.git.robin.murphy@arm.com>

On Wed, Feb 26, 2025 at 03:57:49PM +0000, Robin Murphy wrote:
> This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce.

Minor, style guide says to use fixes format for commit references:

commit ac9a5d522bb8 ("iommu/dma: Fix race condition during iova_domain initialization")

> iommu_dma_init_domain() is now only called under the group mutex, as it
> should be given that that the default domain belongs to the group, so
> the additional internal locking is no longer needed.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>  drivers/iommu/dma-iommu.c | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

  reply	other threads:[~2025-03-05 17:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 15:57 [PATCH] iommu/dma: Remove redundant locking Robin Murphy
2025-03-05 17:30 ` Jason Gunthorpe [this message]
2025-03-10  8:24 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250305173032.GH5011@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --cc=yf.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox