From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FEFC207E05 for ; Tue, 1 Apr 2025 16:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743523425; cv=none; b=gL6ahBY+lkePrzCd7egznaSbRgwKpVMnn2M1YhSGEAVrEY2hHkpszQ4boYIMBK8bWqE8YvoceLbkoTHYEReWfqmqc3R3dS8D6c4AQUH/T2bTkz/33pNeXWL6NQkvLMDP+huKXnGXs6R9+0fmc94Byh1buEIYRUt7PxOPN3/YNfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743523425; c=relaxed/simple; bh=xnUsRAnCTM6iow/f/UCejEdDYoiWEl5F6w3kOCDrBoU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cFt/JWTEJrqCLR9eXwqAklRaNQzo37WsWPGfBwNuv7gBemRuLmHK/gCtVUltCeUA2XMB639ESvrSTk206+b0s5xSwSlY+EA2qIVRbYlXxTET3unutR2F6DfLPBsS+Q5ECdZifwcLAC97VYqlVXt7nTAzn97ZVhwgfTmkk0ryPh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=l9BC5LMG; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="l9BC5LMG" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7c55b53a459so596128285a.3 for ; Tue, 01 Apr 2025 09:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1743523422; x=1744128222; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HUIWAEN6Qyb8+Hz58OV+4wJouq5dad93BnZ8Do0foZI=; b=l9BC5LMGYvsEge/mFcYl7L7meeRNtLQM93U9DYgQO9nLOjsrLOIHlaX0aqbfHcjIGD 7nITP+WNSLL/qA6MB3ps1q55oKD5i8Ax1L9F8ZcJf63pRplqVYNiKrjNHUA8DRJYwrvy rEF+ptbHoqEHDVWBLjLZdTIVRszVenSnoeylqBqg4BQnY5BqBvCxjecIJR0BWeJL76xd x1vCvCdAKJuYH7V9fzVoUNkmj3vIPi1Im1OkdAuixLn8ptzSTz0x8J7F4uSCFLqxQZS/ 15YEhJ+/NS3llH238a4iRq4Lzae9RFq+43sm2wm7zT1Am+FeNDZ7dG+EtXaiCEqaYce1 3Apg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743523422; x=1744128222; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HUIWAEN6Qyb8+Hz58OV+4wJouq5dad93BnZ8Do0foZI=; b=o9r/mS/d3siqmgu/hAC6fU7MR4NjpCC/Mv8UG5p8WKq5tX9we66ATXbjqpYskk9GVO rxZLnkqYeDHsiYcFHG8XLQxYWW6m5iZOSgAqLmam3GlyHwp5Q5LnIkG5xm773bUVulwD hZ0mhHEk4GtzOHX8oq3pof3kqm04XH5HNgKv7XriPktTXx93WNV3neZ0uFZ3o6Ed9Cym kRwpFojQUxdKQMT9a5x+ZMth0ZUtz9hbSowXfzUnDunF2qm3xWmTWOgKm4iuk61kN8P+ hpktwteRrBBg9RUzuiA0EasmTA3rEK8WVP7pvxg6Q58HSoZLpOYsnFz6Q75uO0fSDDaf BJBw== X-Forwarded-Encrypted: i=1; AJvYcCV1brB6tgR9cEFM6lsbBXafy7GtEvS0Sbc+O8nyLovBN4PkcpvABWPqScT/CeIetI/7btZDFw==@lists.linux.dev X-Gm-Message-State: AOJu0YwgEwSEYXP339ffLgrXMjDAcKBnCd4F8DPf3oEnmD+1NRAhxsWz PkLT5v1eZ3jU/t7AHf1sXPPnGON/YK2rCZEN9JiiPzPkl4uQeHrt5wNg9D4bGac= X-Gm-Gg: ASbGncuMN5QKxdiksT8jMRhmD20c1VgAogYBrgOMeQBn0d1V64X/D6OkWQRA3cCzW5B bAwJopYnEtg1hevCvD/21m5MUJl8YGtc8HrQ2kvQV4u/aUHMbVDDrZOYxfCzJBJceFzA2NZbjkH LdyJR92Zyx/gYrSfkU0Qiv6tt+LrnP/JKfERj9r/KxvUnqC6j1zpzuB0qVH+oPIjwwcz0exPlDF Vi3iY8JiEl5PY7odwbL0cvqS76FMidLHDSuwZXV+BNQiInRx9GsyXzFjJXLtCrLntM/khY7QsXo dISYG+SLkoUMV8DecUURzBy5QBb9EQ6vOdMYMS/Pc8npyqHGb4XAIjLX+EeQIWUtRIdaIQ283PH IcRSyVpKDzcJWzSvbQ/AFVR4/8a2Sgk6oQQ== X-Google-Smtp-Source: AGHT+IEK38CnaMLkGKnp6wFhyTba4uVPU2YkYY6SqmlutfADek1SIeamjKZM91laT+FptTnOqcHgWw== X-Received: by 2002:a05:620a:2551:b0:7c5:6045:beb7 with SMTP id af79cd13be357-7c69072c8b5mr2068616685a.32.1743523422038; Tue, 01 Apr 2025 09:03:42 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-219-86.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.219.86]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5f77802c0sm673482385a.104.2025.04.01.09.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 09:03:41 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tze5U-00000001MIe-3oUm; Tue, 01 Apr 2025 13:03:40 -0300 Date: Tue, 1 Apr 2025 13:03:40 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V" Cc: Alexey Kardashevskiy , x86@kernel.org, kvm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Sean Christopherson , Paolo Bonzini , Tom Lendacky , Ashish Kalra , Joerg Roedel , Suravee Suthikulpanit , Robin Murphy , Kevin Tian , Bjorn Helgaas , Dan Williams , Christoph Hellwig , Nikunj A Dadhania , Michael Roth , Vasant Hegde , Joao Martins , Nicolin Chen , Lu Baolu , Steve Sistare , Lukas Wunner , Jonathan Cameron , Suzuki K Poulose , Dionna Glaze , Yi Liu , iommu@lists.linux.dev, linux-coco@lists.linux.dev, Zhi Wang , AXu Yilun Subject: Re: [RFC PATCH v2 14/22] iommufd: Add TIO calls Message-ID: <20250401160340.GK186258@ziepe.ca> References: <20250218111017.491719-1-aik@amd.com> <20250218111017.491719-15-aik@amd.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 28, 2025 at 10:57:18AM +0530, Aneesh Kumar K.V wrote: > > +int iommufd_vdevice_tsm_bind_ioctl(struct iommufd_ucmd *ucmd) > > +{ > > + struct iommu_vdevice_tsm_bind *cmd = ucmd->cmd; > > + struct iommufd_viommu *viommu; > > + struct iommufd_vdevice *vdev; > > + struct iommufd_device *idev; > > + struct tsm_tdi *tdi; > > + int rc = 0; > > + > > + viommu = iommufd_get_viommu(ucmd, cmd->viommu_id); > > + if (IS_ERR(viommu)) > > + return PTR_ERR(viommu); > > > > Would this require an IOMMU_HWPT_ALLOC_NEST_PARENT page table > allocation? Probably. That flag is what forces a S2 page table. > How would this work in cases where there's no need to set up Stage 1 > IOMMU tables? Either attach the raw HWPT of the IOMMU_HWPT_ALLOC_NEST_PARENT or: > Alternatively, should we allocate an IOMMU_HWPT_ALLOC_NEST_PARENT with a > Stage 1 disabled translation config? (In the ARM case, this could mean > marking STE entries as Stage 1 bypass and Stage 2 translate.) For arm you mean IOMMU_HWPT_DATA_ARM_SMMUV3.. But yes, this can work too and is mandatory if you want the various viommu linked features to work. > Also, if a particular setup doesn't require creating IOMMU > entries because the entire guest RAM is identity-mapped in the IOMMU, do > we still need to make tsm_tdi_bind use this abstraction in iommufd? Even if the viommu will not be exposed to the guest I'm expecting that iommufd will have a viommu object, just not use various features. We are using viommu as the handle for the KVM, vmid and other things that are likely important here. Jason