Re: [PATCH v5 8/8] iommu: Remove iommu_dev_enable/disable_feature()

Nicolin Chen
2025-04-18T20:24:08Z

On Fri, Apr 18, 2025 at 04:01:30PM +0800, Lu Baolu wrote:
> No external drivers use these interfaces anymore. Furthermore, no existing
> iommu drivers implement anything in the callbacks. Remove them to avoid
> dead code.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Tested-by: Zhangfei Gao <zhangfei.gao@linaro.org>

Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>

With the following:

> @@ -657,9 +647,6 @@ struct iommu_ops {
> bool (*is_attach_deferred)(struct device *dev);
>
> /* Per device IOMMU features */
> - int (*dev_enable_feat)(struct device *dev, enum iommu_dev_features f);
> - int (*dev_disable_feat)(struct device *dev, enum iommu_dev_features f);

They should be dropped in the kdoc too.