From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Will McVicker <willmcvicker@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
"Rob Herring (Arm)" <robh@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <jroedel@suse.de>,
Bjorn Helgaas <bhelgaas@google.com>,
iommu@lists.linux.dev, Saravana Kannan <saravanak@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] platform: Fix race condition during DMA configure at IOMMU probe time
Date: Wed, 23 Apr 2025 13:58:05 -0300 [thread overview]
Message-ID: <20250423165805.GH1213339@ziepe.ca> (raw)
In-Reply-To: <20250423150823.GA422889@bhelgaas>
On Wed, Apr 23, 2025 at 10:08:23AM -0500, Bjorn Helgaas wrote:
> I think this would all be clearer if we tested for the NULL pointer
> explicitly before applying to_platform_driver(). I don't like setting
> a pointer to an invalid value. I think it's better if the pointer is
> either valid or uninitialized because the compiler can help find uses
> of uninitialized pointers.
+1
Jason
prev parent reply other threads:[~2025-04-23 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 23:26 [PATCH v1] platform: Fix race condition during DMA configure at IOMMU probe time Will McVicker
2025-04-23 15:08 ` Bjorn Helgaas
2025-04-23 15:50 ` Robin Murphy
2025-04-23 16:57 ` Jason Gunthorpe
2025-04-23 17:27 ` William McVicker
2025-04-23 16:58 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423165805.GH1213339@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux.dev \
--cc=jroedel@suse.de \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox