From: Jason Gunthorpe <jgg@nvidia.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: baolu.lu@linux.intel.com, kevin.tian@intel.com,
yi.l.liu@intel.com, dwmw2@infradead.org, joro@8bytes.org,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Subject: Re: [PATCH v1] iommu/vt-d: Remove redundant SLTS cap check for nested and dirty tracking
Date: Fri, 6 Jun 2025 14:15:23 -0300 [thread overview]
Message-ID: <20250606171523.GJ19710@nvidia.com> (raw)
In-Reply-To: <20250605101052.955174-1-wei.w.wang@intel.com>
On Thu, Jun 05, 2025 at 06:10:52PM +0800, Wei Wang wrote:
> In intel_iommu_domain_alloc_paging_flags():
> For the nested_parent case, nested_supported() has been check earlier,
> and for the dirty_tracking case, ssads_supported() has been check earlier.
> Both of these imply SLTS support, making the subsequent SLTS cap check
> redundant.
> Also, false-initialize the first_stage boolean to simplify the code.
>
> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> ---
> drivers/iommu/intel/iommu.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
I'm going to post a patch that fixes this (and the other one you sent)
differently next week:
https://github.com/jgunthorpe/linux/commits/iommu_pt_vtd/
iommu/vtd: Split intel_iommu_domain_alloc_paging_flags()
Jason
prev parent reply other threads:[~2025-06-06 17:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 10:10 [PATCH v1] iommu/vt-d: Remove redundant SLTS cap check for nested and dirty tracking Wei Wang
2025-06-06 17:15 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606171523.GJ19710@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wei.w.wang@intel.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox