From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Jacob Pan <jacob.pan@linux.microsoft.com>,
linux-kernel@vger.kernel.org,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"Liu, Yi L" <yi.l.liu@intel.com>,
Zhang Yu <zhangyu1@microsoft.com>,
Easwar Hariharan <eahariha@linux.microsoft.com>,
Saurabh Sengar <ssengar@linux.microsoft.com>
Subject: Re: [PATCH v2 2/2] vfio: Fix unbalanced vfio_df_close call in no-iommu mode
Date: Mon, 16 Jun 2025 17:05:58 -0300 [thread overview]
Message-ID: <20250616200558.GR1174925@nvidia.com> (raw)
In-Reply-To: <20250616134004.60105ad5.alex.williamson@redhat.com>
On Mon, Jun 16, 2025 at 01:40:04PM -0600, Alex Williamson wrote:
> --- a/drivers/vfio/group.c
> +++ b/drivers/vfio/group.c
> @@ -192,18 +192,18 @@ static int vfio_df_group_open(struct vfio_device_file *df)
> * implies they expected translation to exist
> */
> if (!capable(CAP_SYS_RAWIO) ||
> - vfio_iommufd_device_has_compat_ioas(device, df->iommufd))
> + vfio_iommufd_device_has_compat_ioas(device, df->iommufd)) {
> ret = -EPERM;
> - else
> - ret = 0;
> - goto out_put_kvm;
> + goto out_put_kvm;
> + }
> }
>
>
> And add a noiommu exit branch to _iommufd_bind, symmetric to unbind.
> Right? Thanks,
Just comparing to the original
+ if (iommufd) {
+ if (!vfio_device_is_noiommu(device))
+ ret = vfio_df_iommufd_bind(df);
Isn't being captured, so it needs another hunk in
vfio_df_iommufd_bind()
Jason
next prev parent reply other threads:[~2025-06-16 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 15:23 [PATCH v2 1/2] vfio: Prevent open_count decrement to negative Jacob Pan
2025-06-03 15:23 ` [PATCH v2 2/2] vfio: Fix unbalanced vfio_df_close call in no-iommu mode Jacob Pan
2025-06-13 22:31 ` Alex Williamson
2025-06-14 0:15 ` Jason Gunthorpe
2025-06-16 14:47 ` Alex Williamson
2025-06-16 15:34 ` Jason Gunthorpe
2025-06-16 19:40 ` Alex Williamson
2025-06-16 20:05 ` Jason Gunthorpe [this message]
2025-06-18 23:11 ` Jacob Pan
2025-06-18 23:25 ` Jason Gunthorpe
2025-06-13 22:31 ` [PATCH v2 1/2] vfio: Prevent open_count decrement to negative Alex Williamson
2025-06-14 0:09 ` Jason Gunthorpe
2025-06-16 14:40 ` Alex Williamson
2025-06-18 23:08 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616200558.GR1174925@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=eahariha@linux.microsoft.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=yi.l.liu@intel.com \
--cc=zhangyu1@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox