From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AF37374283 for ; Thu, 21 Aug 2025 20:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806910; cv=none; b=RwfmsUgMxnrafiJv3V3l3++WCXxNq0APq48HirBvYfoSVWB3y30LN5JuTDtJIAXmdpr59bVsClTnHhtn47o0QaNZvKfdxRCEz4v42hMBDRUlmWYYHbDylnIFcNQJmw5vdfaOZ+fEfs1A0xqVAqavMd/++Z1vGgIzxaKYBdMazWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806910; c=relaxed/simple; bh=bq2gWh1hWRAlT57D1zXSNbOueAtiEim7ETzHNFHN/Ro=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=awMYkKkGDkcFq3hgysHr53Ks39vZcVF/D0Bw+FEmUxo4UK3RqCUI2FW0M/sOWo4vXmE2E5sCAf9gsU+LKtux6mmP79My7y4boijLiY52cC0vIEXQiS4PbpMe19dthKdBWqi5DgZIw5zQHn++EH6cqFgp1UsGtQvTo+HexZ8rD8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DpJ2gAzW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DpJ2gAzW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yR/3u5W37RASrGsn/s3pQVQ78UUgH4ByCavV3b4UG3M=; b=DpJ2gAzWYwi7Z9Viv2yUpZ7N1lD0RdYGI/sPgYXnlupS2AH6sXLySPpgMos2zuETN9W14L e0gW2avxc0iiw7xV8wOmW0OMUEJNoron21zFbawAq/1u6csGxhGbsjknuPmfMn3XsRsaCS 2B3Tt+Fth9wJqNKKRa3Tchr1gEJuXtw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-WLU0WLCOO-eAQzfszNUBwQ-1; Thu, 21 Aug 2025 16:08:24 -0400 X-MC-Unique: WLU0WLCOO-eAQzfszNUBwQ-1 X-Mimecast-MFC-AGG-ID: WLU0WLCOO-eAQzfszNUBwQ_1755806904 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45a15fd6b45so10809165e9.1 for ; Thu, 21 Aug 2025 13:08:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806904; x=1756411704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yR/3u5W37RASrGsn/s3pQVQ78UUgH4ByCavV3b4UG3M=; b=OdaykiWoA4nemj8NorLkedEDjZsqgSwkc9+RvDiMH4uD9EOz8is6w2nYId3xcbwfy3 Gnxlp+CD61g/VG5fX7lpvWs7PQWeXGVnEstj2sEvIOot8OfPC+192Y5Ge9sydUnR3ZBW D5sjFvQGt3SQZZTKmaqZRU12kPloZEEswUFbHTQd2DgWiw3dvg3+oxtfI0VKUF2zshqx tZypGY7cJld/2+7ZK/LYiIuOEXNZo95UX3UfypcfPxuY/+Hv9RuSCQbWK8OX3ytYLVjv jM/jNJqp5jhYJL07ov3RwVgjwr2/QzdG0bt97LLP6I2K3+SWLS6GFokMqjUDI3F7XNQm Ez0w== X-Forwarded-Encrypted: i=1; AJvYcCVPjAdz5TfOCcqBLe29/UQepdM2naEsOj5LYxHI1eSmihlcpZvIxxWxdSKVtA+FjLScRZZbFw==@lists.linux.dev X-Gm-Message-State: AOJu0Yy6pnD4ekXRSn6x70nc8nc9EqPapwGi1x3PSr5MqkNV4Ha5PULu 8zGKeJLhPzWyINttCJ5jTgGdtJN4J6cJaN5fyw1dpf+X/tvdpoZfzPHy59KkystApMp0h+Hg2Ac RqkulqieN2V+6+HEN6bQBz+m2wrbo3rVz5dHMq2nVEt42D/lwYDht+ms8 X-Gm-Gg: ASbGncvSYIvkaHJW/Ccyvl1at4Ad/PvfqxtCU6J/etgbchrqUk46UmMNJRvvqFlX9I2 WUg9FWOELuAJC/e9QjjPgH2573QBhy/vr2i1bGhQQX1mdspYEr/+dFWky2m2fdNug4RsxYiomFI enOPPg+rQ8ks6GWQ3hZVTVWDup+S05P8tSEJh1fj/TBcxgA+t4aFfVX1vBVkDqcNLuI+9OILdQV ErBxkoVykxqDhu8gC5iZx7CKo2HL4P5vaIeHNe3M/8F2ltqGl4C80QrllUr2dDS8bsNcqqmK3FR LWKjWN7SPrhZjrT+Db7mzgjLjBHS9TdMyz1vIxSvkLT8gWQHF5FLKR9xdw00FZLiPL0DSOhnxKv qBVFA6YxqAvZfMpw9t+lnmQ== X-Received: by 2002:a05:6000:310e:b0:3c3:5406:12b0 with SMTP id ffacd0b85a97d-3c5d53b40abmr247278f8f.30.1755806903624; Thu, 21 Aug 2025 13:08:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+53ePp4gOBoZK5+aLlST4uu6G3xHtHBUa0vmdrbtPfJ4bf44S3Zn2IpCr0m84pAneAOD81g== X-Received: by 2002:a05:6000:310e:b0:3c3:5406:12b0 with SMTP id ffacd0b85a97d-3c5d53b40abmr247245f8f.30.1755806903113; Thu, 21 Aug 2025 13:08:23 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3c0771c1708sm13032145f8f.38.2025.08.21.13.08.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:08:22 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Maxim Levitsky , Alex Dubov , Ulf Hansson , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 27/35] memstick: drop nth_page() usage within SG entry Date: Thu, 21 Aug 2025 22:06:53 +0200 Message-ID: <20250821200701.1329277-28-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: icRI7DA_x2q5F7cgdwwP_VmccGKH8_iy-dO0ySME9Ws_1755806904 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true It's no longer required to use nth_page() when iterating pages within a single SG entry, so let's drop the nth_page() usage. Cc: Maxim Levitsky Cc: Alex Dubov Cc: Ulf Hansson Signed-off-by: David Hildenbrand --- drivers/memstick/host/jmb38x_ms.c | 3 +-- drivers/memstick/host/tifm_ms.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c index cddddb3a5a27f..c5e71d39ffd51 100644 --- a/drivers/memstick/host/jmb38x_ms.c +++ b/drivers/memstick/host/jmb38x_ms.c @@ -317,8 +317,7 @@ static int jmb38x_ms_transfer_data(struct jmb38x_ms_host *host) unsigned int p_off; if (host->req->long_data) { - pg = nth_page(sg_page(&host->req->sg), - off >> PAGE_SHIFT); + pg = sg_page(&host->req->sg) + off / PAGE_SIZE; p_off = offset_in_page(off); p_cnt = PAGE_SIZE - p_off; p_cnt = min(p_cnt, length); diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c index db7f3a088fb09..0d64184ca10a9 100644 --- a/drivers/memstick/host/tifm_ms.c +++ b/drivers/memstick/host/tifm_ms.c @@ -201,8 +201,7 @@ static unsigned int tifm_ms_transfer_data(struct tifm_ms *host) unsigned int p_off; if (host->req->long_data) { - pg = nth_page(sg_page(&host->req->sg), - off >> PAGE_SHIFT); + pg = sg_page(&host->req->sg) + off / PAGE_SIZE; p_off = offset_in_page(off); p_cnt = PAGE_SIZE - p_off; p_cnt = min(p_cnt, length); -- 2.50.1