From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842E737DEFB for ; Thu, 21 Aug 2025 20:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806929; cv=none; b=t9ma7zS4VbG4eOOp0bTITF0UZ12AVjrtM5A2k2/8B6WAPrROwAj2cXdUW+tbRNO2TuO0agKv3fEkQ1dki8FSuQs/QBEC31OSFAd3B936bOI9ae38k8OvlXPhq8MahYSUZ1zL3crHQEhybd8Np0Hrs9X6OsD/C4FamAK0xGaXqM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755806929; c=relaxed/simple; bh=izYuZWtM9expuJ4aw1W3JEFW5k9djBINp3Pti4HydYU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:content-type; b=K53AP79phKYgy3ztUNT48YtZy++2BPWNJSBZpQ0J7e1eMtGYTVJSvbz5ICwM2FeN1tAo0Wa7lf90fPiiyFDFRDV2lajmgivSsHFwrEIYPGBLIlNzAirw+SIRPiKz+ReKn89ZdJN2hl0DVpXQEj3wir1KNuhOplCRCD8jPBL1QI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=N3GKuT+u; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N3GKuT+u" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755806926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7iPpUiW3LrFM0W3XrB+Z82uodwKTsefoCzXwhLbLUo=; b=N3GKuT+u+DvWAvpzT2+mvlAtduXZobTWJI+3sLR4n+mBp55UgBmZqrwcbah/wnQnuNvIpR nWpNVe5FqYr5gneMGqTlrYfsxr8VObYpfaB6lwP/3SfYXYILP+0irgqowy1Vk+Wvjvhkmw yHGVkgAZZBwaMGshQcCZhzTVuOoI4Tk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-WD3YNgZOME2u1_hjA2tBgA-1; Thu, 21 Aug 2025 16:08:44 -0400 X-MC-Unique: WD3YNgZOME2u1_hjA2tBgA-1 X-Mimecast-MFC-AGG-ID: WD3YNgZOME2u1_hjA2tBgA_1755806923 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3b9edf2d82dso666861f8f.2 for ; Thu, 21 Aug 2025 13:08:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755806923; x=1756411723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z7iPpUiW3LrFM0W3XrB+Z82uodwKTsefoCzXwhLbLUo=; b=GU4JAWU+QOmtSG7Ej6WHhSX4S3mFwDbFQRIUUxc34HRzUDT5WUo/0DWJOJZNoFGHta wf5payvxadqw8eQpJsBuYkS9fr3gYUZo6aIOZ1CXMv6XuqPOOAKH2txpBLYfrd6dmpjs yoz1igBvGBZZ1K1jhUrnlXBU3QLViV37FSsUhBrMqoyYY+84848Aa0XKnjFbCAv2J+ok T1hkv7RI4ACKccrrRGunnORLsvpuBuRyREgtGf317A4EhlF72CPhnAvcKMi1STDKNUXT X09q5WZ3U7pIkClrtwYv1uMxBHgRB1tonAwsuIKjIp+UiVNMksKTHli0ArxAcbDBkiu1 3Z6g== X-Forwarded-Encrypted: i=1; AJvYcCXLR8YgDSuRs3+88q7thTgboTk/QAhU0Fg1u6nv26hyUJ3kGPzlTOXaiFg+rm4BtM73wmYICg==@lists.linux.dev X-Gm-Message-State: AOJu0Yxbd7PkSkoU58NgE6R26AH3grq1joXpiOJNLDVLXzcQvIhnJfYm WSC+NqFzlMPM4TeDA/MXsat4ZxaxBB6RmLHwZMJ2KkfU1EkgrS7sWCzUVYjfsRmntqsNZk5Uh/0 Z/SpkcazaY1SfrgveM9YHS+y/DY8hPjPk2+6xtnZsHT9kpLvxLs7fpU5s X-Gm-Gg: ASbGncs/IvQaBthxh0/Sx7IhHKpvReEd4PzFX8FLZuwerxttz8nDCuYtpiOaKT2BHz2 bUkZIBreL/5I4WAk7XaA/yoEfd0G9BjfFKZpMOdxCEQLLkddtlyYMhCiMPh2zQ4tTpXWiIeHpVY WvJqIgiZ/4CnkV1SCKp2Y9HdywhmUBnztXv5mjbF3Uel2wSh94RoCcQFQMmV8mgIDxN2rgtixYf Ou0IBLE/lUU9u4WTRxYPuLXK1pNoij9YSoY53MQgAbMo9ux5wtDQ6SqGebuydEOgamUhpLl6UYb A8K22gkcgtzU6R3paK27tfnJxtCchSSkoweAz5S1Eb87t+CvS5EpahxIcqeRtKLqTxi8SV8mpNy Vk3NlGrD96kXND/h8T+GN7A== X-Received: by 2002:a5d:64ed:0:b0:3b5:dafc:1525 with SMTP id ffacd0b85a97d-3c5dc7313famr204706f8f.33.1755806922973; Thu, 21 Aug 2025 13:08:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnHzRKC08dohUKQD/XdldMc6IWYVddiLtTh8Yidep5vx+5++gzVG23SiimMwYZ+HldR36Zkg== X-Received: by 2002:a5d:64ed:0:b0:3b5:dafc:1525 with SMTP id ffacd0b85a97d-3c5dc7313famr204645f8f.33.1755806922505; Thu, 21 Aug 2025 13:08:42 -0700 (PDT) Received: from localhost (p200300d82f26ba0008036ec5991806fd.dip0.t-ipconnect.de. [2003:d8:2f26:ba00:803:6ec5:9918:6fd]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-45b50e3a587sm10028205e9.18.2025.08.21.13.08.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Aug 2025 13:08:42 -0700 (PDT) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: [PATCH RFC 34/35] block: update comment of "struct bio_vec" regarding nth_page() Date: Thu, 21 Aug 2025 22:07:00 +0200 Message-ID: <20250821200701.1329277-35-david@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250821200701.1329277-1-david@redhat.com> References: <20250821200701.1329277-1-david@redhat.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Md53ugV_eBVu6s36xFh47R13vaYIu3Sq8z4krvfIdv4_1755806923 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Ever since commit 858c708d9efb ("block: move the bi_size update out of __bio_try_merge_page"), page_is_mergeable() no longer exists, and the logic in bvec_try_merge_page() is now a simple page pointer comparison. Signed-off-by: David Hildenbrand --- include/linux/bvec.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/include/linux/bvec.h b/include/linux/bvec.h index 0a80e1f9aa201..3fc0efa0825b1 100644 --- a/include/linux/bvec.h +++ b/include/linux/bvec.h @@ -22,11 +22,8 @@ struct page; * @bv_len: Number of bytes in the address range. * @bv_offset: Start of the address range relative to the start of @bv_page. * - * The following holds for a bvec if n * PAGE_SIZE < bv_offset + bv_len: - * - * nth_page(@bv_page, n) == @bv_page + n - * - * This holds because page_is_mergeable() checks the above property. + * All pages within a bio_vec starting from @bv_page are contiguous and + * can simply be iterated (see bvec_advance()). */ struct bio_vec { struct page *bv_page; -- 2.50.1