From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 790CB32898F for ; Wed, 17 Sep 2025 14:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758117756; cv=none; b=YnVyVaxtM0EcZQ4Vtp+jIYm4OxmY+z8I8HPEki/X/QklUksWY1OB69FWDXNVqhK+5oT1lIE1tVUMdxiaDcvWBkgV/FkvAq9XYq8BLhc8sRwJ+tiz+JbN0dIwYrFoc+6xTn2oQhtFSyFfU1H3lxZR1AMPKGk71z/vqHq9DJIzRsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758117756; c=relaxed/simple; bh=mOW2tsFUm15DmZmv5idmWrqtHcDQ5+Yigq54v02aKPI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=KaA/aQ+m4O+JTw35M069LKRw3zBYUIv5i5QZ4/8uxuefbqFnYCpPRbmOOgeorO9MthCDXJykvOi/ajX1wh9ub7YIgAF51VXc+vtfn/guauSu6dY/RNA2Je85GtAC9C4vZGVYb+CGy6Ra2cazRHqliuGjB8IiEubB2v/A4krHxEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qa/0BFD2; arc=none smtp.client-ip=209.85.218.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qa/0BFD2" Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-b0438a5f20fso699334166b.3 for ; Wed, 17 Sep 2025 07:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1758117753; x=1758722553; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MbS5VM8JWBvxciJaUjLtcORna4KntSfvz669tBLnIuo=; b=qa/0BFD2vVdn1Oa+/zIKdnJNpddp+uchASgVdOV41WBtyM9m4dU58rurhvDfQy3eys 7aElU6SRPq05FDnvYYlWereVYrKrQJ+OScrwlv5Rxw548+VUE99kOCO4+BXJ/GERXZ+n CBC2KLhAns0ehW+ONy9QLX6cMKRnGIoXCd1NsQnljxWW61OO/2xrVR6g/khx4YP/z8Ol m+1P63m7iqvMvJ/Czinv6jlLgV4Ke23c4f8A89fT5Pm2vBlqY7iCd7VqwT9LXbRoc+1l YlHeUo+AgcKRKV6FxjuFT/yJpFN5paJl76yYImlhhf+5froJEkU2Jj7qMdBa3/nZc07+ dIHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758117753; x=1758722553; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MbS5VM8JWBvxciJaUjLtcORna4KntSfvz669tBLnIuo=; b=fmA/ZaXFGhf1htveRmuCSV+v8R6T199TQrSg6K68DqeHSOEvO+yB3aWYXHr4mas83Y My84vGxm6j/E9aMVZd695pIyAtkfPhMkzmW46W/wieQ70ehV+qkFQ35pCQ0CIeF13Yfu 4n+/voQvJb848oiGof2ospAUDfmzdbN7qGlw4OGV7NMyxwx+4rTiMaI+7PWag47C8TjT akZjZYKSMDjdq3JM7SGD096Nw+SRXNkZrBgZ1SQJu3rX79LnSwFzCC+afOAcTrcdTYCb PbQJDYSdHw7MRJl/mUZugBrhb+sn6vGeIXoSB6Surbspk6Zr9Zr4RrP9fWlfIBpeizQn 790Q== X-Gm-Message-State: AOJu0Yw4Jcz4KohscUz9uoj0yXd2e7EfehH0X0p+voRPusJ6BhA8y+j7 MLqmrIQPvjBPnWJJWde8vUI4nlaGcEzodG7pJv33saQpv1KcqSI8QzLupBfiEQ4RasvdonlRxHg d7i9qhOPJwEi+eImwyjPG1yLqdbxUZp+CApb11CthGtYZVSS7FD8JD/pdYoD6C9H5uLnRh44oCG Agk/xriHfrZ8EAjFQdg13eEAqZQhOpYwPRtoPbQ6+XaN+nyg== X-Google-Smtp-Source: AGHT+IE3jLGXIoEmh8JZSWjISt/98EKsWlH7hx945hGGOLLiBVFnNJMHLIN27ohSmsi4BE4MwPLjrgToCtD6zg== X-Received: from edben16.prod.google.com ([2002:a05:6402:5290:b0:62f:464a:b98b]) (user=smostafa job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:3f0a:b0:b0c:6cae:51e3 with SMTP id a640c23a62f3a-b1bb8ca5382mr283095066b.35.1758117752675; Wed, 17 Sep 2025 07:02:32 -0700 (PDT) Date: Wed, 17 Sep 2025 14:02:03 +0000 In-Reply-To: <20250917140216.2199055-1-smostafa@google.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250917140216.2199055-1-smostafa@google.com> X-Mailer: git-send-email 2.51.0.384.g4c02a37b29-goog Message-ID: <20250917140216.2199055-3-smostafa@google.com> Subject: [PATCH 2/2] iommu/io-pgtable-arm-selftest: Use KUnit From: Mostafa Saleh To: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, jgg@ziepe.ca, praan@google.com, Mostafa Saleh Content-Type: text/plain; charset="UTF-8" Integrate the selftests as part of kunit, this makes the results of the test available through debugfs later. Suggested-by: Jason Gunthorpe Signed-off-by: Mostafa Saleh --- drivers/iommu/Kconfig | 2 +- drivers/iommu/io-pgtable-arm-selftests.c | 90 ++++++++++++++---------- 2 files changed, 52 insertions(+), 40 deletions(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index 70d29b14d851..52c2fcb0e77f 100644 --- a/drivers/iommu/Kconfig +++ b/drivers/iommu/Kconfig @@ -42,7 +42,7 @@ config IOMMU_IO_PGTABLE_LPAE config IOMMU_IO_PGTABLE_LPAE_SELFTEST bool "LPAE selftests" - depends on IOMMU_IO_PGTABLE_LPAE + depends on IOMMU_IO_PGTABLE_LPAE && KUNIT=y help Enable self-tests for LPAE page table allocator. This performs a series of page-table consistency checks during boot. diff --git a/drivers/iommu/io-pgtable-arm-selftests.c b/drivers/iommu/io-pgtable-arm-selftests.c index f7746ff2c7a0..3775936d07c7 100644 --- a/drivers/iommu/io-pgtable-arm-selftests.c +++ b/drivers/iommu/io-pgtable-arm-selftests.c @@ -6,6 +6,8 @@ * * Author: Will Deacon */ +#include +#include #include #include #include @@ -39,25 +41,26 @@ static const struct iommu_flush_ops dummy_tlb_ops __initconst = { .tlb_add_page = dummy_tlb_add_page, }; -static void __init arm_lpae_dump_ops(struct io_pgtable_ops *ops) +static void __init arm_lpae_dump_ops(struct kunit *test, struct io_pgtable_ops *ops) { struct arm_lpae_io_pgtable *data = io_pgtable_ops_to_data(ops); struct io_pgtable_cfg *cfg = &data->iop.cfg; - pr_err("cfg: pgsize_bitmap 0x%lx, ias %u-bit\n", - cfg->pgsize_bitmap, cfg->ias); - pr_err("data: %d levels, 0x%zx pgd_size, %u pg_shift, %u bits_per_level, pgd @ %p\n", - ARM_LPAE_MAX_LEVELS - data->start_level, ARM_LPAE_PGD_SIZE(data), - ilog2(ARM_LPAE_GRANULE(data)), data->bits_per_level, data->pgd); + kunit_err(test, "cfg: pgsize_bitmap 0x%lx, ias %u-bit\n", + cfg->pgsize_bitmap, cfg->ias); + kunit_err(test, "data: %d levels, 0x%zx pgd_size, %u pg_shift, %u bits_per_level, pgd @ %p\n", + ARM_LPAE_MAX_LEVELS - data->start_level, ARM_LPAE_PGD_SIZE(data), + ilog2(ARM_LPAE_GRANULE(data)), data->bits_per_level, data->pgd); } -#define __FAIL(ops, i) ({ \ - WARN(1, "selftest: test failed for fmt idx %d\n", (i)); \ - arm_lpae_dump_ops(ops); \ - -EFAULT; \ +#define __FAIL(test, ops, i) ({ \ + KUNIT_FAIL(test, ""); \ + kunit_err(test, "selftest: test failed for fmt idx %d\n", (i)); \ + arm_lpae_dump_ops(test, ops); \ + -EFAULT; \ }) -static int __init arm_lpae_run_tests(struct io_pgtable_cfg *cfg) +static int __init arm_lpae_run_tests(struct kunit *test, struct io_pgtable_cfg *cfg) { static const enum io_pgtable_fmt fmts[] __initconst = { ARM_64_LPAE_S1, @@ -73,7 +76,7 @@ static int __init arm_lpae_run_tests(struct io_pgtable_cfg *cfg) cfg_cookie = cfg; ops = alloc_io_pgtable_ops(fmts[i], cfg, cfg); if (!ops) { - pr_err("selftest: failed to allocate io pgtable ops\n"); + kunit_err(test, "selftest: failed to allocate io pgtable ops\n"); return -ENOMEM; } @@ -82,13 +85,13 @@ static int __init arm_lpae_run_tests(struct io_pgtable_cfg *cfg) * Empty page tables shouldn't provide any translations. */ if (ops->iova_to_phys(ops, 42)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); if (ops->iova_to_phys(ops, SZ_1G + 42)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); if (ops->iova_to_phys(ops, SZ_2G + 42)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); /* * Distinct mappings of different granule sizes. @@ -101,16 +104,16 @@ static int __init arm_lpae_run_tests(struct io_pgtable_cfg *cfg) IOMMU_READ | IOMMU_WRITE | IOMMU_NOEXEC | IOMMU_CACHE, GFP_KERNEL, &mapped)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); /* Overlapping mappings */ if (!ops->map_pages(ops, iova, iova + size, size, 1, IOMMU_READ | IOMMU_NOEXEC, GFP_KERNEL, &mapped)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); if (ops->iova_to_phys(ops, iova + 42) != (iova + 42)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); iova += SZ_1G; } @@ -121,18 +124,18 @@ static int __init arm_lpae_run_tests(struct io_pgtable_cfg *cfg) size = 1UL << j; if (ops->unmap_pages(ops, iova, size, 1, NULL) != size) - return __FAIL(ops, i); + return __FAIL(test, ops, i); if (ops->iova_to_phys(ops, iova + 42)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); /* Remap full block */ if (ops->map_pages(ops, iova, iova, size, 1, IOMMU_WRITE, GFP_KERNEL, &mapped)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); if (ops->iova_to_phys(ops, iova + 42) != (iova + 42)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); iova += SZ_1G; } @@ -148,11 +151,11 @@ static int __init arm_lpae_run_tests(struct io_pgtable_cfg *cfg) IOMMU_READ | IOMMU_WRITE | IOMMU_NOEXEC | IOMMU_CACHE, GFP_KERNEL, &mapped)) - return __FAIL(ops, i); + return __FAIL(test, ops, i); if (mapped != size) - return __FAIL(ops, i); + return __FAIL(test, ops, i); if (ops->unmap_pages(ops, iova, size, 1, NULL) != size) - return __FAIL(ops, i); + return __FAIL(test, ops, i); free_io_pgtable_ops(ops); } @@ -160,7 +163,7 @@ static int __init arm_lpae_run_tests(struct io_pgtable_cfg *cfg) return 0; } -static int __init arm_lpae_do_selftests(void) +static void __init io_pgtable_arm_test_run(struct kunit *test) { static const unsigned long pgsize[] __initconst = { SZ_4K | SZ_2M | SZ_1G, @@ -173,18 +176,19 @@ static int __init arm_lpae_do_selftests(void) }; int i, j, k, pass = 0, fail = 0; - struct faux_device *dev; + struct device *dev; struct io_pgtable_cfg cfg = { .tlb = &dummy_tlb_ops, .coherent_walk = true, .quirks = IO_PGTABLE_QUIRK_NO_WARN, }; - dev = faux_device_create("io-pgtable-test", NULL, 0); - if (!dev) - return -ENOMEM; + dev = kunit_device_register(test, "io-pgtable-test"); + KUNIT_EXPECT_NOT_ERR_OR_NULL(test, dev); + if (IS_ERR_OR_NULL(dev)) + return; - cfg.iommu_dev = &dev->dev; + cfg.iommu_dev = dev; for (i = 0; i < ARRAY_SIZE(pgsize); ++i) { for (j = 0; j < ARRAY_SIZE(address_size); ++j) { @@ -193,9 +197,9 @@ static int __init arm_lpae_do_selftests(void) cfg.pgsize_bitmap = pgsize[i]; cfg.ias = address_size[k]; cfg.oas = address_size[j]; - pr_info("selftest: pgsize_bitmap 0x%08lx, IAS %u OAS %u\n", - pgsize[i], cfg.ias, cfg.oas); - if (arm_lpae_run_tests(&cfg)) + kunit_info(test, "selftest: pgsize_bitmap 0x%08lx, IAS %u OAS %u\n", + pgsize[i], cfg.ias, cfg.oas); + if (arm_lpae_run_tests(test, &cfg)) fail++; else pass++; @@ -203,9 +207,17 @@ static int __init arm_lpae_do_selftests(void) } } - pr_info("selftest: completed with %d PASS %d FAIL\n", pass, fail); - faux_device_destroy(dev); - - return fail ? -EFAULT : 0; + kunit_info(test, "selftest: completed with %d PASS %d FAIL\n", pass, fail); } -subsys_initcall(arm_lpae_do_selftests); + +static struct kunit_case io_pgtable_arm_test_cases[] __refdata = { + KUNIT_CASE(io_pgtable_arm_test_run), + {}, +}; + +static struct kunit_suite io_pgtable_arm_test = { + .name = "io-pgtable-arm-test", + .test_cases = io_pgtable_arm_test_cases, +}; + +kunit_test_init_section_suite(io_pgtable_arm_test); -- 2.51.0.384.g4c02a37b29-goog