From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47D252D027F; Mon, 20 Oct 2025 04:56:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760936198; cv=none; b=eo/y5Nzbuh/kLPWTjcP63kADXIhi4YGkE0W4AZX4UL4aDH9Z7tjEmQO4iL8kJ5ErXTAMJhk6V6jClyn1/Qb5N4Czdd714MuaBGOpEmWTFUeAF7fJpHYd5E3uJFXaAFPFdUv2BgzHr+htUKj9RtgrWw9RR6PPBpuiEYuLFw1irFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760936198; c=relaxed/simple; bh=I1WdqYJWLR3PNSOWKpin7GH4bbZsu9qz49UM1zdBbDo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OYD2ciEpDJLHz8QfNYew0qTTbmCPnVhIhs4jU+0lY1PQIRYV9zHMczaqokbe46yoBUMoWrhZJRgkjltMcYyQG8FHt1MD5oIJ7lIs4gZY/RwvRsV9DLa+QrEwz+w6pM1tKKQmRezuNpsnLepFg0MBWa6xP2x0zi/XQsEQ0AB4PYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NE+3MNAL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NE+3MNAL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19C44C4CEFE; Mon, 20 Oct 2025 04:56:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760936198; bh=I1WdqYJWLR3PNSOWKpin7GH4bbZsu9qz49UM1zdBbDo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NE+3MNAL8pCWwQSpY+zdGeHjh9pQQO7YW3PLk/0h1w4tkRIQnZwbujBnxt9upN9Kz QaoSzBCd5rZMXQWMYvepUk8XAJQ/Ov/9YlSFR+sWJHJX8VVE1ePHbV2jP8AffTmw13 uFaFwzxy3YO2vLeSM+B8I6gskE/XTbFWylcacZ+osCM4hwmZ7KTXxxsZYUTi8jTJTa QAJ4q6jCkBpY6cxzmJNOY6N0B4NzM3I1REv4nDifgOY0AIpTcBz0Sr5u4zZCEH9gcb q4wWObZDOOnnVSrW5U+CkmWCOgfi/DCHyS+B7YbFgwCj7gb0WxGNBMZeQ8vchE7i/G FYX8FlWmFgOlQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vAhwo-0000000083i-0NeK; Mon, 20 Oct 2025 06:56:42 +0200 From: Johan Hovold To: Joerg Roedel , Will Deacon Cc: Robin Murphy , Sven Peter , Janne Grunau , Rob Clark , Marek Szyprowski , Yong Wu , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Thierry Reding , Krishna Reddy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Miaoqian Lin , Thierry Reding Subject: [PATCH v3 14/14] iommu/tegra: fix device leak on probe_device() Date: Mon, 20 Oct 2025 06:53:18 +0200 Message-ID: <20251020045318.30690-15-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20251020045318.30690-1-johan@kernel.org> References: <20251020045318.30690-1-johan@kernel.org> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make sure to drop the reference taken to the iommu platform device when looking up its driver data during probe_device(). Note that commit 9826e393e4a8 ("iommu/tegra-smmu: Fix missing put_device() call in tegra_smmu_find") fixed the leak in an error path, but the reference is still leaking on success. Fixes: 891846516317 ("memory: Add NVIDIA Tegra memory controller support") Cc: stable@vger.kernel.org # 3.19: 9826e393e4a8 Cc: Miaoqian Lin Acked-by: Robin Murphy Acked-by: Thierry Reding Signed-off-by: Johan Hovold --- drivers/iommu/tegra-smmu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index 36cdd5fbab07..f6f26a072820 100644 --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -830,10 +830,9 @@ static struct tegra_smmu *tegra_smmu_find(struct device_node *np) return NULL; mc = platform_get_drvdata(pdev); - if (!mc) { - put_device(&pdev->dev); + put_device(&pdev->dev); + if (!mc) return NULL; - } return mc->smmu; } -- 2.49.1