From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E00E31ED96 for ; Wed, 19 Nov 2025 13:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763559334; cv=none; b=FjEdmgaDDeKzuVZVMjS94AoAF1+IxrjKC8CtAMLg0zk8QNd98Uwt8ssQQIx+gqhMUsU6HjV0CX8awQccv7QE47vKPP2nJzkmNPnfcwBh5fLS1XU54IYKNiO9nqfVhY+ZtiILxcJIhmcKsmN3GKB5IJcy6Qfss6tdHJGceGrn2Bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763559334; c=relaxed/simple; bh=JbbhmQiTlI31d28XPGRBqj9eq2p7XGaOpuCDuXLlBNA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ABinw5B/kUvhOhKEqy+opI24sUlBtdHlDTZroQJg8C21xkk3rMos0wbZoE5eUyCgyz8bt4C2FUGzOBRdQcOVrXxuRiClD5nsKsfHwwk283zc0isOVe9wLXeCCBjv6ikAz96UgpqUerZV2vk//0KL9+MWHRYYKRMZLpIqmSqZ8P0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=OMV7Q4By; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="OMV7Q4By" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4ed7024c8c5so49788831cf.3 for ; Wed, 19 Nov 2025 05:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1763559331; x=1764164131; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=72A2miNlT6HYTvn6gfrMP1LsN3+/rcjlJPwocEiTvrs=; b=OMV7Q4BytdoeH98maQ3OGKkB4fAgSfMWpZho4iaZL9uI65SWaBOqS5GCOxmTRrXHYV LRwp1yCR5wsTbz7KyKs0P9i5SEIc6PxZ/NImYma4lZYByyMjwTVOKXs/RXF0DK1AIriC +6svlhegAqhy8wXlszokQIazYt51yZtB8OcMauE0TcKV6LaWuGCISDwrF0TbaAB/enGs vP2ZyOIHWIrB0qOVSsE+48+L91WUuprHPhi9+QWS9R+h5dQsdi8Qq5k9eGtzNrEVxSUu wUEzPUJeA/CTFwML2GhmhJaULiXCcdiQ4ScyxbIGXSrxxyfZrwZkbLyjfzME22kaD/AU 04Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763559331; x=1764164131; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=72A2miNlT6HYTvn6gfrMP1LsN3+/rcjlJPwocEiTvrs=; b=fETSzilEoc4M+z4gQ+Z9mBRM1G1SGJ1ELoWiZIOM/7U8x6wVEnq+QdFdmH/qy02Ea6 imQizhR4G/OMEtgBjIStPwI4W6RvBUAMY4H5uQATmH0LdAsKMNeaJz++RA2J7lufyQBE hav9WXUqg7SmDGS7Atw+NoikSMKkxAhNlgqX37g2uvRkEa+wd8WGJa9ctkX7mfls20Rs BjZgX36yzWv/HfB5cUcJZBd3Hw2xJetcrHbh8XpSAqY9zsG2JujLGah1u6z5Pz1V2KiB ph9Fu2HPQrn7+voyPNC+qaH9DfIwUKZcirXDdcgsfb35HxGSn5Fd/hHr0VQsEBjkhjXe ddjA== X-Forwarded-Encrypted: i=1; AJvYcCVbL1iDlKXSxAOIbIX8Heck2U3gqhICuHltS0vu87to0D0bN8aOEtUUhZVwFw5SpKsuq/H6vw==@lists.linux.dev X-Gm-Message-State: AOJu0YxxnFcgS0gPgIUlUmC69/FDJGzXzsqp0OR78mCeE1uy9wf5KL0v Yumor8Twp0aFeOEjv+EE9UIQIABEAnVGfc1atyHVit01GxBejKTKXHQ0bm2IzjHylaI= X-Gm-Gg: ASbGncuLpApBGQBUSsKYnScVpOiCF330z7Zq8eNHJSSkKAQd29oFpDnh9+V6FRGPpEw JTQtfofbjphmztcMgYJGJpgUTfx0Ks/maAJIbJgIf1EH9PDoJ6u44QTT42uJdiVC7Z1P5eD2A33 uqnom7ZomzphPEDmaGif3KwhgF7dBaR4Xpp5syksR3RxldJwS6vvYbi3aHtst4blnAwjvhidPxr 41RlVgPZ1rdBaPkfp8CMmjNGIZJe4FylBA0jZVHXPVio0WD7wHxoi5ExWm6mFENrqhU35oufHjz IdtjJ/ttLLtOUcVePBdyUZ29+8g7u+mXIge/vYexP56FWeAU0ns3dztjjVwAf5r+DCxszV/5Gsc drYxrABe0V9lw0T2GZQBP8ldXvCtAXK6z36pG2wZ5M/B2gZKKVjZqMmwmaLlxpfIuOJ1Mnu68D5 lCM6rtBUQ6RxFo38rwLn0/cn2DsWpaDLrf5m6/wDm4VAgFEw7c6SoeLdFF X-Google-Smtp-Source: AGHT+IE7dgToIwQMvgHU78QddWp+ZiJRe5Ch8SPXRMVN2DOwf2T1NT7zeC+YapS6FYUcpx8f/T/2tw== X-Received: by 2002:a05:622a:256:b0:4ee:16a8:dd0 with SMTP id d75a77b69052e-4ee16a8d595mr193299331cf.53.1763559331028; Wed, 19 Nov 2025 05:35:31 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4ede86b376dsm127986771cf.7.2025.11.19.05.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 05:35:30 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vLiLJ-00000000Z9b-1C3G; Wed, 19 Nov 2025 09:35:29 -0400 Date: Wed, 19 Nov 2025 09:35:29 -0400 From: Jason Gunthorpe To: Christian =?utf-8?B?S8O2bmln?= Cc: Leon Romanovsky , Bjorn Helgaas , Logan Gunthorpe , Jens Axboe , Robin Murphy , Joerg Roedel , Will Deacon , Marek Szyprowski , Andrew Morton , Jonathan Corbet , Sumit Semwal , Kees Cook , "Gustavo A. R. Silva" , Ankit Agrawal , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Krishnakant Jaju , Matt Ochs , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, iommu@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, kvm@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v8 05/11] PCI/P2PDMA: Document DMABUF model Message-ID: <20251119133529.GL17968@ziepe.ca> References: <20251111-dmabuf-vfio-v8-0-fd9aa5df478f@nvidia.com> <20251111-dmabuf-vfio-v8-5-fd9aa5df478f@nvidia.com> <9798b34c-618b-4e89-82b0-803bc655c82b@amd.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9798b34c-618b-4e89-82b0-803bc655c82b@amd.com> On Wed, Nov 19, 2025 at 10:18:08AM +0100, Christian König wrote: > > +As this is not well-defined or well-supported in real HW the kernel defaults to > > +blocking such routing. There is an allow list to allow detecting known-good HW, > > +in which case P2P between any two PCIe devices will be permitted. > > That section sounds not correct to me. It is correct in that it describes what the kernel does right now. See calc_map_type_and_dist(), host_bridge_whitelist(), cpu_supports_p2pdma(). > This is well supported in current HW, it's just not defined in some > official specification. Only AMD HW. Intel HW is a bit hit and miss. ARM SOCs are frequently not supporting even on server CPUs. > > +At the lowest level the P2P subsystem offers a naked struct p2p_provider that > > +delegates lifecycle management to the providing driver. It is expected that > > +drivers using this option will wrap their MMIO memory in DMABUF and use DMABUF > > +to provide an invalidation shutdown. > > > These MMIO pages have no struct page, and > > Well please drop "pages" here. Just say MMIO addresses. "These MMIO addresses have no struct page, and" > > +Building on this, the subsystem offers a layer to wrap the MMIO in a ZONE_DEVICE > > +pgmap of MEMORY_DEVICE_PCI_P2PDMA to create struct pages. The lifecycle of > > +pgmap ensures that when the pgmap is destroyed all other drivers have stopped > > +using the MMIO. This option works with O_DIRECT flows, in some cases, if the > > +underlying subsystem supports handling MEMORY_DEVICE_PCI_P2PDMA through > > +FOLL_PCI_P2PDMA. The use of FOLL_LONGTERM is prevented. As this relies on pgmap > > +it also relies on architecture support along with alignment and minimum size > > +limitations. > > Actually that is up to the exporter of the DMA-buf what approach is used. The above is not talking about DMA-buf, it is describing the existing interface that is all struct page based. The driver invoking the P2PDMA APIs gets to pick if it uses the stuct page based interface described above or the lower level p2p provider interface this series introduces. > For the P2PDMA API it should be irrelevant if struct pages are used or not. Only for the lowest level p2p provider based P2PDMA API - there is a higher level API family within P2PDMA's API that is all about creating and managing ZONE_DEVICE struct pages and a pgmap, the above describes that family. Thanks, Jason