From: Jason Gunthorpe <jgg@nvidia.com>
To: Chunyu Hu <chuhu@redhat.com>
Cc: Joerg Roedel <joro@8bytes.org>, iommu@lists.linux.dev
Subject: Re: Question: AMD IOMMU v1 contiguous PTE OA encoding triggers FIELD_PREP overflow
Date: Tue, 13 Jan 2026 17:12:58 -0400 [thread overview]
Message-ID: <20260113211258.GA955618@nvidia.com> (raw)
In-Reply-To: <20260108005244.GA537065@ziepe.ca>
On Wed, Jan 07, 2026 at 08:52:44PM -0400, Jason Gunthorpe wrote:
> > In file included from <command-line>:
> > In function ‘amdv1pt_install_leaf_entry’,
> > inlined from ‘__do_map_single_page’ at drivers/iommu/generic_pt/fmt/../iommu_pt.h:651:3,
> > inlined from ‘__map_single_page0’ at drivers/iommu/generic_pt/fmt/../iommu_pt.h:662:1,
> > inlined from ‘pt_descend’ at drivers/iommu/generic_pt/fmt/../pt_iter.h:391:9,
> > inlined from ‘__do_map_single_page’ at drivers/iommu/generic_pt/fmt/../iommu_pt.h:658:10,
> > inlined from ‘__map_single_page1.constprop’ at drivers/iommu/generic_pt/fmt/../iommu_pt.h:662:1:
Does this work for you? clang 18 hit the same issue and it fixed it there:
diff --git a/drivers/iommu/generic_pt/iommu_pt.h b/drivers/iommu/generic_pt/iommu_pt.h
index 14a73d3b291b42..a46f1dadefd521 100644
--- a/drivers/iommu/generic_pt/iommu_pt.h
+++ b/drivers/iommu/generic_pt/iommu_pt.h
@@ -691,7 +691,7 @@ static __always_inline int __do_map_single_page(struct pt_range *range,
struct pt_iommu_map_args *map = arg;
pts.type = pt_load_single_entry(&pts);
- if (level == 0) {
+ if (pts.level == 0) {
if (pts.type != PT_ENTRY_EMPTY)
return -EADDRINUSE;
pt_install_leaf_entry(&pts, map->oa, PAGE_SHIFT,
prev parent reply other threads:[~2026-01-13 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 2:26 Question: AMD IOMMU v1 contiguous PTE OA encoding triggers FIELD_PREP overflow Chunyu Hu
2026-01-08 0:52 ` Jason Gunthorpe
2026-01-13 21:12 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113211258.GA955618@nvidia.com \
--to=jgg@nvidia.com \
--cc=chuhu@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox