From: Jason Gunthorpe <jgg@ziepe.ca>
To: Yu Zhang <zhangyu1@linux.microsoft.com>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>,
Samiullah Khawaja <skhawaja@google.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommupt: Always add IOVA range to iotlb_gather in gather_range_pages()
Date: Mon, 2 Feb 2026 12:05:22 -0400 [thread overview]
Message-ID: <20260202160522.GJ2328995@ziepe.ca> (raw)
In-Reply-To: <20260202095458.882560-1-zhangyu1@linux.microsoft.com>
On Mon, Feb 02, 2026 at 05:54:58PM +0800, Yu Zhang wrote:
> diff --git a/drivers/iommu/generic_pt/iommu_pt.h b/drivers/iommu/generic_pt/iommu_pt.h
> index d575f3ba9d34..3e33fe64feab 100644
> --- a/drivers/iommu/generic_pt/iommu_pt.h
> +++ b/drivers/iommu/generic_pt/iommu_pt.h
> @@ -58,10 +58,9 @@ static void gather_range_pages(struct iommu_iotlb_gather *iotlb_gather,
> * Note that the sync frees the gather's free list, so we must
> * not have any pages on that list that are covered by iova/len
> */
> - } else if (pt_feature(common, PT_FEAT_FLUSH_RANGE)) {
> - iommu_iotlb_gather_add_range(iotlb_gather, iova, len);
> }
>
> + iommu_iotlb_gather_add_range(iotlb_gather, iova, len);
> iommu_pages_list_splice(free_list, &iotlb_gather->freelist);
> }
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
This should have a
Cc: stable@vger.kernel.org
It is a serious error.
Thanks,
Jason
prev parent reply other threads:[~2026-02-02 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 9:54 [PATCH] iommupt: Always add IOVA range to iotlb_gather in gather_range_pages() Yu Zhang
2026-02-02 16:05 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202160522.GJ2328995@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=will@kernel.org \
--cc=zhangyu1@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox