From: Jason Gunthorpe <jgg@ziepe.ca>
To: Viktor Kleen <viktor@kleen.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Treat PAGE_SNOOP and PWSNP separately
Date: Mon, 2 Feb 2026 19:43:34 -0400 [thread overview]
Message-ID: <20260202234334.GM2328995@ziepe.ca> (raw)
In-Reply-To: <20260202192109.1665799-1-viktor@kleen.org>
On Mon, Feb 02, 2026 at 07:21:05PM +0000, Viktor Kleen wrote:
> The PASID_FLAG_PAGE_SNOOP and PASID_FLAG_PWSNP constants are identical.
> This will cause the pasid code to always set both or neither of the
> PGSNP and PWSNP bits in PASID table entries. However, PWSNP is a
> reserved bit if SMPWC is not set in the IOMMU's extended capability
> register, even if SC is supported.
>
> This has resulted in DMAR errors when testing the iommufd code on an
> Arrow Lake platform. With this patch, those errors disappear and the
> PASID table entries look correct.
>
> Fixes: 101a2854110fa ("iommu/vt-d: Follow PT_FEAT_DMA_INCOHERENT into the PASID entry")
> Signed-off-by: Viktor Kleen <viktor@kleen.org>
> ---
> drivers/iommu/intel/pasid.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
It looks like a typo to me too
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
It should also be:
Cc: stable@vger.kernel.org
Jason
next prev parent reply other threads:[~2026-02-02 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 19:21 [PATCH] iommu/vt-d: Treat PAGE_SNOOP and PWSNP separately Viktor Kleen
2026-02-02 23:43 ` Jason Gunthorpe [this message]
2026-02-05 8:34 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202234334.GM2328995@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=viktor@kleen.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox