Re: [PATCH kernel 7/9] coco/sev-guest: Implement the guest support for SEV TIO (phase2)

Borislav Petkov
2026-02-26T19:54:46Z

On February 26, 2026 3:39:37 AM UTC, Alexey Kardashevskiy <aik@amd.com> wrote:
>I struggle to separate these more without making individual patches useless for any purpose

You sound like someone who hasn't been reviewing patches and scratching his head how to approach such a conglomerate as yours which does many things at once...

The rule is very simple actually: a patch should do one logical thing only. And no more. It doesn't matter whether the patch is "useless" by itself. It matters only whether it is reviewable and one can to a certain degree see that the transformation it contains is relatively bugfree.

And I'm very sure that when you start reviewing patches, you'll be pretty much asking people sending conglomerates like yours, to split them.

Thx.
--
Small device. Typos and formatting crap