From: Jason Gunthorpe <jgg@ziepe.ca>
To: Ankit Soni <Ankit.Soni@amd.com>
Cc: iommu@lists.linux.dev, vasant.hegde@amd.com,
suravee.suthikulpanit@amd.com, joro@8bytes.org, will@kernel.org,
robin.murphy@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Adhere to IVINFO[VASIZE] for address limits
Date: Tue, 3 Mar 2026 14:17:53 -0400 [thread overview]
Message-ID: <20260303181753.GE964116@ziepe.ca> (raw)
In-Reply-To: <4yddupv5soxmatbmcqqs4ndsffbls4r6eagoiaebalnlikx2jw@wtdby7qs6nz6>
On Tue, Mar 03, 2026 at 05:11:07PM +0000, Ankit Soni wrote:
> > I mean if FIELD_GET(IOMMU_IVINFO_VASIZE, amd_iommu_ivinfo) is 35 why
> > not just pass it to hw_max_vasz_lg2 and be done with it? What is the
> > point of limiting to only a few values?
> >
> > Jason
>
> I got your point, i added the check to match the spec, which defines valid
> values are only 32, 40, 48, and 64.
I don't think you should do that.. The valid values are the only ones
a hypervisor should install, but the kernel should be permissive and
accept everything..
Certainly it makes little sense to get something like 35 and expand it
to 64.
Jason
next prev parent reply other threads:[~2026-03-03 18:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 16:58 [PATCH] iommu/amd: Adhere to IVINFO[VASIZE] for address limits Ankit Soni
2026-02-28 10:56 ` kernel test robot
2026-03-02 23:57 ` Jason Gunthorpe
2026-03-03 11:47 ` Ankit Soni
2026-03-03 12:05 ` Jason Gunthorpe
2026-03-03 17:11 ` Ankit Soni
2026-03-03 18:17 ` Jason Gunthorpe [this message]
2026-03-05 13:51 ` Ankit Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303181753.GE964116@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Ankit.Soni@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox