From: Jason Gunthorpe <jgg@ziepe.ca>
To: Pranjal Shrivastava <praan@google.com>
Cc: iommu@lists.linux.dev, Will Deacon <will@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>,
Ankit Soni <Ankit.Soni@amd.com>,
Samiullah Khawaja <skhawaja@google.com>,
syzbot+453eb7add07c3767adab@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] iommufd/selftest: Remove MOCK_IOMMUPT_AMDV1 format
Date: Tue, 31 Mar 2026 13:25:29 -0300 [thread overview]
Message-ID: <20260331162529.GK246076@ziepe.ca> (raw)
In-Reply-To: <20260330092609.2659235-1-praan@google.com>
On Mon, Mar 30, 2026 at 09:26:09AM +0000, Pranjal Shrivastava wrote:
> syzbot found that allocating a mock domain with AMDV1 format could
> cause a WARN_ON because the selftest enabled DYNAMIC_TOP without
> providing the required driver_ops.
>
> The AMDV1 format in the selftest was a placeholder and was not actually
> used by any of the existing selftests. Instead of adding dummy
> driver_ops to satisfy the requirements of a format we don't currently
> test, remove the AMDV1 format option from the selftest.
>
> The MOCK_IOMMUPT_DEFAULT and MOCK_IOMMUPT_HUGE formats are unaffected as
> they use the amdv1_mock variant which does not enable DYNAMIC_TOP.
>
> Fixes: dcd6a011a8d5 ("iommupt: Add map_pages op")
> Reported-by: syzbot+453eb7add07c3767adab@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/all/69c1d50b.a70a0220.3cae05.0001.GAE@google.com/
> Signed-off-by: Pranjal Shrivastava <praan@google.com>
> ---
> drivers/iommu/iommufd/iommufd_test.h | 1 -
> drivers/iommu/iommufd/selftest.c | 31 ----------------------------
> 2 files changed, 32 deletions(-)
Applied to for-next
Thanks,
Jason
prev parent reply other threads:[~2026-03-31 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 9:26 [PATCH v2] iommufd/selftest: Remove MOCK_IOMMUPT_AMDV1 format Pranjal Shrivastava
2026-03-31 16:25 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331162529.GK246076@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Ankit.Soni@amd.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=syzbot+453eb7add07c3767adab@syzkaller.appspotmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox