Linux IOMMU Development
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Peiyang He <peiyang_he@smail.nju.edu.cn>
Cc: kevin.tian@intel.com, joro@8bytes.org, will@kernel.org,
	robin.murphy@arm.com, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG] iommufd/selftest: fault injection in iommufd_get_object can trigger a teardown UAF
Date: Mon, 13 Jul 2026 14:23:36 -0300	[thread overview]
Message-ID: <20260713172336.GF3133966@ziepe.ca> (raw)
In-Reply-To: <870BB9ADBBEDDD1A+37c5bfab-ad32-4fc5-a302-57c81a8432b5@smail.nju.edu.cn>

On Fri, Jul 10, 2026 at 01:46:55PM +0800, Peiyang He wrote:
> Hello Linux kernel developers and maintainers,
> 
> We found a KMSAN use-after-free in iommu_device_release_dma_owner
> warning when fuzzing IOMMUFD with selftest with Syzkaller.
> 
> After our digging, we believe this UAF has limited impact, but it
> exposes a possible improvement on how fault injection is handled in
> iommufd_device_pre_destroy().
> 
> The root cause for this UAF is that iommufd_device_pre_destroy()
> uses the fault-injectable iommufd_get_object(), causing it to
> mistakenly assume that the vdev destruction has been taken over by
> another thread.  More detailed analysis will be given below.

Yeah, I made a different fix for this than you suggested. See the
patch I'll post..

Thanks,
Jason

      reply	other threads:[~2026-07-13 17:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10  5:46 [BUG] iommufd/selftest: fault injection in iommufd_get_object can trigger a teardown UAF Peiyang He
2026-07-13 17:23 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260713172336.GF3133966@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peiyang_he@smail.nju.edu.cn \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox