From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: Will Deacon <will@kernel.org>, Kiryl Shutsemau <kas@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Pranjal Shrivastava <praan@google.com>,
Breno Leitao <leitao@debian.org>, Kyle McMartin <jkkm@meta.com>,
Usama Arif <usama.arif@linux.dev>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iommu/arm-smmu-v3: Shrink command/event/PRI queues in kdump kernel
Date: Tue, 4 Aug 2026 13:19:18 -0300 [thread overview]
Message-ID: <20260804161918.GG27883@nvidia.com> (raw)
In-Reply-To: <anINkO1l9Kz8lTVh@nvidia.com>
On Tue, Aug 04, 2026 at 09:04:32AM -0700, Nicolin Chen wrote:
> On Tue, Aug 04, 2026 at 11:17:04AM -0300, Jason Gunthorpe wrote:
> > On Tue, Aug 04, 2026 at 03:02:46PM +0100, Will Deacon wrote:
> > > > Would skipping their allocation when is_kdump_kernel() be acceptable on
> > > > its own, or would you rather see it done differently?
> > >
> > > With Nicolin's patch, we can just avoid allocating the priq and the evtq
> > > entirely in the kdump case. We can then add a cmdline option to control
> > > the maximum size of the cmdq, which is useful regardless of kdump.
> >
> > I would still prefer kdump do this re-sizing automatically, even if we
> > do add a commandline. It makes it easire to deploy than having to know
> > secret command lines :\
> >
> > So functionally I still think this patch is fine, though yes it points
> > out more things in Nicolin's work too.
>
> I will send a v10 of mine, to skip the EVTQ/PRIQ allocations.
I think Robin's point is to structure the v10 so you introduce a bunch
of tunables, including something like 0 size to disable a feature.
Then have kdump default those tunables to the right thing
Jason
next prev parent reply other threads:[~2026-08-04 16:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 8:47 [PATCH v3] iommu/arm-smmu-v3: Shrink command/event/PRI queues in kdump kernel Kiryl Shutsemau (Meta)
2026-07-15 11:46 ` Kiryl Shutsemau
2026-07-27 9:30 ` Kiryl Shutsemau
2026-07-28 10:16 ` Will Deacon
2026-07-28 13:53 ` Kiryl Shutsemau
2026-08-04 14:02 ` Will Deacon
2026-08-04 14:17 ` Jason Gunthorpe
2026-08-04 15:23 ` Robin Murphy
2026-08-04 16:04 ` Nicolin Chen
2026-08-04 16:19 ` Jason Gunthorpe [this message]
2026-08-04 16:45 ` Nicolin Chen
2026-08-04 16:59 ` Jason Gunthorpe
2026-08-04 17:39 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804161918.GG27883@nvidia.com \
--to=jgg@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jkkm@meta.com \
--cc=joro@8bytes.org \
--cc=kas@kernel.org \
--cc=leitao@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=usama.arif@linux.dev \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox