From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
Joerg Roedel <joro@8bytes.org>,
"Raj, Ashok" <ashok.raj@intel.com>,
Christoph Hellwig <hch@infradead.org>,
Jason Gunthorpe <jgg@nvidia.com>
Cc: Will Deacon <will@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v2 03/12] iommu/vt-d: Remove clearing translation data in disable_dmar_iommu()
Date: Tue, 14 Jun 2022 15:21:23 +0800 [thread overview]
Message-ID: <28161d94-6f2d-700f-853d-53b42f4d00d0@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB52762E7602FFF7EE4B52AC888CAA9@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2022/6/14 14:49, Tian, Kevin wrote:
>> From: Lu Baolu<baolu.lu@linux.intel.com>
>> Sent: Tuesday, June 14, 2022 10:51 AM
>>
>> The disable_dmar_iommu() is called when IOMMU initialization fails or
>> the IOMMU is hot-removed from the system. In both cases, there is no
>> need to clear the IOMMU translation data structures for devices.
>>
>> On the initialization path, the device probing only happens after the
>> IOMMU is initialized successfully, hence there're no translation data
>> structures.
> Out of curiosity. With kexec the IOMMU may contain stale mappings
> from the old kernel. Then is it meaningful to disable IOMMU after the
> new kernel fails to initialize it properly?
For kexec kernel, if the IOMMU is detected to be pre-enabled, the IOMMU
driver will try to copy tables from the old kernel. If copying table
fails, the IOMMU driver will disable IOMMU and do the normal
initialization.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-06-14 7:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 2:51 [PATCH v2 00/12] iommu/vt-d: Optimize the use of locks Lu Baolu
2022-06-14 2:51 ` [PATCH v2 01/12] iommu/vt-d: debugfs: Remove device_domain_lock usage Lu Baolu
2022-06-14 6:43 ` Tian, Kevin
2022-06-14 7:15 ` Baolu Lu
2022-06-15 1:53 ` Baolu Lu
2022-06-15 6:13 ` Tian, Kevin
2022-06-15 13:02 ` Baolu Lu
2022-06-14 2:51 ` [PATCH v2 02/12] iommu/vt-d: Remove for_each_device_domain() Lu Baolu
2022-06-14 2:51 ` [PATCH v2 03/12] iommu/vt-d: Remove clearing translation data in disable_dmar_iommu() Lu Baolu
2022-06-14 6:49 ` Tian, Kevin
2022-06-14 7:21 ` Baolu Lu [this message]
2022-06-15 6:22 ` Tian, Kevin
2022-06-15 13:10 ` Baolu Lu
2022-06-16 4:00 ` Tian, Kevin
2022-06-14 2:51 ` [PATCH v2 04/12] iommu/vt-d: Use pci_get_domain_bus_and_slot() in pgtable_walk() Lu Baolu
2022-06-14 2:51 ` [PATCH v2 05/12] iommu/vt-d: Unnecessary spinlock for root table alloc and free Lu Baolu
2022-06-14 2:51 ` [PATCH v2 06/12] iommu/vt-d: Acquiring lock in domain ID allocation helpers Lu Baolu
2022-06-14 6:52 ` Tian, Kevin
2022-06-14 7:22 ` Baolu Lu
2022-06-14 2:51 ` [PATCH v2 07/12] iommu/vt-d: Acquiring lock in pasid manipulation helpers Lu Baolu
2022-06-14 2:51 ` [PATCH v2 08/12] iommu/vt-d: Replace spin_lock_irqsave() with spin_lock() Lu Baolu
2022-06-14 6:56 ` Tian, Kevin
2022-06-14 2:51 ` [PATCH v2 09/12] iommu/vt-d: Check device list of domain in domain free path Lu Baolu
2022-06-14 6:57 ` Tian, Kevin
2022-06-14 2:51 ` [PATCH v2 10/12] iommu/vt-d: Fold __dmar_remove_one_dev_info() into its caller Lu Baolu
2022-06-14 7:07 ` Tian, Kevin
2022-06-14 7:44 ` Baolu Lu
2022-06-14 2:51 ` [PATCH v2 11/12] iommu/vt-d: Use device_domain_lock accurately Lu Baolu
2022-06-14 7:16 ` Tian, Kevin
2022-06-14 7:47 ` Baolu Lu
2022-06-14 2:51 ` [PATCH v2 12/12] iommu/vt-d: Convert global spinlock into per domain ones Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28161d94-6f2d-700f-853d-53b42f4d00d0@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox