From: Lu Baolu <baolu.lu@linux.intel.com>
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iommu/vt-d: Add new enum value and structure for SATC
Date: Wed, 3 Feb 2021 08:15:16 +0800 [thread overview]
Message-ID: <2d623a51-f9ed-b955-4bc0-aed5ad6a4cef@linux.intel.com> (raw)
In-Reply-To: <20210202160203.GC39643@otc-nc-03>
Hi Ashok,
On 2/3/21 12:02 AM, Raj, Ashok wrote:
> On Tue, Feb 02, 2021 at 12:40:55PM +0800, Lu Baolu wrote:
>> From: Yian Chen <yian.chen@intel.com>
>>
>> Starting from Intel Platform VT-d v3.2, BIOS may provide new remapping
>> structure SATC for SOC integrated devices, according to section 8.8 of
>> Intel VT-d architecture specification v3.2. The SATC structure reports
>> a list of the devices that require SATC enabling via ATS capacity.
>
> nit: s/require SATC/require ATS for normal device operation. This is a
> functional requirement that these devices will not work without OS enabling
> ATS capability.
>
Yes. This looks clearer.
Best regards,
baolu
>>
>> This patch introduces the new enum value and structure to represent the
>> remapping information. Kernel should parse the information from the
>> reporting structure and enable ATC for the devices as needed.
>>
>> Signed-off-by: Yian Chen <yian.chen@intel.com>
>> ---
>> include/acpi/actbl1.h | 11 ++++++++++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
>> index 43549547ed3e..b7ca802b66d2 100644
>> --- a/include/acpi/actbl1.h
>> +++ b/include/acpi/actbl1.h
>> @@ -514,7 +514,8 @@ enum acpi_dmar_type {
>> ACPI_DMAR_TYPE_ROOT_ATS = 2,
>> ACPI_DMAR_TYPE_HARDWARE_AFFINITY = 3,
>> ACPI_DMAR_TYPE_NAMESPACE = 4,
>> - ACPI_DMAR_TYPE_RESERVED = 5 /* 5 and greater are reserved */
>> + ACPI_DMAR_TYPE_SATC = 5,
>> + ACPI_DMAR_TYPE_RESERVED = 6 /* 5 and greater are reserved */
>> };
>>
>
> Think Joerg spotted the comment update.
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-02-03 0:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 4:40 [PATCH 0/3] iommu/vt-d: Add support for ACPI/SATC table Lu Baolu
2021-02-02 4:40 ` [PATCH 1/3] iommu/vt-d: Add new enum value and structure for SATC Lu Baolu
2021-02-02 13:51 ` Joerg Roedel
2021-02-03 0:11 ` Lu Baolu
2021-02-02 16:02 ` Raj, Ashok
2021-02-03 0:15 ` Lu Baolu [this message]
2021-02-02 4:40 ` [PATCH 2/3] iommu/vt-d: Parse SATC reporting structure Lu Baolu
2021-02-02 13:53 ` Joerg Roedel
2021-02-03 0:26 ` Lu Baolu
2021-02-02 16:41 ` Raj, Ashok
2021-02-03 0:29 ` Lu Baolu
2021-02-02 4:40 ` [PATCH 3/3] iommu/vt-d: Apply SATC policy Lu Baolu
2021-02-02 13:55 ` Joerg Roedel
2021-02-03 0:33 ` Lu Baolu
2021-02-03 8:41 ` [PATCH 0/3] iommu/vt-d: Add support for ACPI/SATC table Christoph Hellwig
2021-02-03 9:29 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d623a51-f9ed-b955-4bc0-aed5ad6a4cef@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox